[GitHub] [commons-numbers] aherbert commented on a diff in pull request #133: NUMBERS-194: GCD JavaDoc mention coprimes check

["aherbert (via GitHub)" <gi...@apache.org>]

aherbert commented on code in PR #133:
URL: https://github.com/apache/commons-numbers/pull/133#discussion_r1263045991


##########
commons-numbers-core/src/main/java/org/apache/commons/numbers/core/ArithmeticUtils.java:
##########
@@ -58,6 +58,8 @@ private ArithmeticUtils() {
      *   for the special cases above.</li>
      *  <li>The invocation {@code gcd(0, 0)} is the only one which returns
      *   {@code 0}.</li>
+     *   <li>gcd can be used to determine if two numbers are relatively prime.

Review Comment:
   This has been added as a special case. It is not a special case, it is a usage example. It should be moved to a new paragraph, e.g.
   ```
   <p>Two numbers are relatively prime, or coprime, if their gcd is 1.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org