[GitHub] [activemq-artemis] fvaleri edited a comment on issue #3043: ARTEMIS-2682: OpenWireMessageConverter refactoring

[GitBox <gi...@apache.org>]

fvaleri edited a comment on issue #3043: ARTEMIS-2682: OpenWireMessageConverter refactoring
URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-611066861
 
 
   Hi the build failure seems to be related to a Travis environment issue. I can successfully run the same build command without issues.
   ```log
   No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
   ```
   
   @clebertsuconic this is what I've done:
   
   - removed `OpenwireMessage` bean because it was just an empty implementation and no other class was using it
   - given that the inbound and outbound conversion logic was already distinct inside the  `OpenWireMessageConverter` class, I made it as Singleton that is now calling `OpenWireMessageConverter.createInboundMessage` and `CoreOpenWireConverter.createMessageDispatch`
   - the conversion logic inside previous methods is exactly the same as it was, I just removed some minor code duplication (*)
   - created `OpenWireMessageSupport` class to host some simple utility methods and to group all property constants that are in common between `OpenWireMessageConverter` and `CoreOpenWireConverter`. This class also useful in unit tests.
   
   (*) you can easily see my changes by comparing the following:
   - `OpenWireMessageConverter.inbound` --> `OpenWireCoreConverter.createInboundMessage`
   - `OpenWireMessageConverter.createMessageDispatch` --> `CoreOpenWireConverter.createMessageDispatch`
   
   I know it's just a starter, but I'm really looking forward to your comments. I think the converter is much more manageable than before and, along with unit tests, it should allow us to be more confident in case of future changes.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services