You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2021/12/03 11:39:27 UTC
[ofbiz-framework] 01/05: Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
commit a7183cba55faf4d6c9c06d48591396a06aa8eb16
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Fri Dec 3 04:02:11 2021 +0100
Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
Add a comment about test methods not used OOTB
---
.../org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java | 2 ++
1 file changed, 2 insertions(+)
diff --git a/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java b/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java
index 1473b9c..1abb193 100644
--- a/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java
+++ b/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java
@@ -845,6 +845,7 @@ public class MacroFormRendererTest {
modelForm.getPaginateTarget(withNotNull());
result = targetService;
// FIXME SpotBugs reports: Argument 1 is definitely null but must not be null
+ // Also this method is not used at all OOTB
requestHandler.makeLink(null, null, withSubstring(qbeString));
result = linkFromQbeString;
}
@@ -872,6 +873,7 @@ public class MacroFormRendererTest {
modelForm.getPaginateTarget(withNotNull());
result = paginateTarget;
// FIXME SpotBugs reports: Argument 1 is definitely null but must not be null
+ // Also this method is not used at all OOTB
requestHandler.makeLink(null, null, withSubstring(qbeString));
result = linkFromQbeString;