You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/09 14:48:41 UTC

[GitHub] [commons-imaging] b923 opened a new pull request #73: IMAGING-253: ByteSourceInputStream has initialized its length when reading starts

b923 opened a new pull request #73: IMAGING-253: ByteSourceInputStream has initialized its length when reading starts
URL: https://github.com/apache/commons-imaging/pull/73
 
 
   The reason was that `streamLength` property was never initialized.
   
   Also added test for verification

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-imaging] b923 commented on issue #73: IMAGING-253: ByteSourceInputStream has initialized its length when reading starts

Posted by GitBox <gi...@apache.org>.
b923 commented on issue #73: IMAGING-253: ByteSourceInputStream has initialized its length when reading starts
URL: https://github.com/apache/commons-imaging/pull/73#issuecomment-612141614
 
 
   Thank you @kinow

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-imaging] kinow commented on issue #73: IMAGING-253: ByteSourceInputStream has initialized its length when reading starts

Posted by GitBox <gi...@apache.org>.
kinow commented on issue #73: IMAGING-253: ByteSourceInputStream has initialized its length when reading starts
URL: https://github.com/apache/commons-imaging/pull/73#issuecomment-611870075
 
 
   Merged. Change looked good, included a test and no other failures. Formatted a bit the test file to include newline at the end of the file and use 4-spaces. Added a changes.xml and updated JIRA ticket too to include it in the next release. Thanks a lot @b923 !!! 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-imaging] coveralls commented on issue #73: IMAGING-253: ByteSourceInputStream has initialized its length when reading starts

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #73: IMAGING-253: ByteSourceInputStream has initialized its length when reading starts
URL: https://github.com/apache/commons-imaging/pull/73#issuecomment-611619404
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29972186/badge)](https://coveralls.io/builds/29972186)
   
   Coverage increased (+0.2%) to 75.267% when pulling **16542336428953de63876ab62e77f1318f67945d on b923:IMAGING-253_ByteSourceInputStream-has-initialized-length-when-reading** into **1397ca92cd3268b434ad8a18529ee3544bbcf3c5 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-imaging] kinow closed pull request #73: IMAGING-253: ByteSourceInputStream has initialized its length when reading starts

Posted by GitBox <gi...@apache.org>.
kinow closed pull request #73: IMAGING-253: ByteSourceInputStream has initialized its length when reading starts
URL: https://github.com/apache/commons-imaging/pull/73
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services