You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/11 14:42:47 UTC
[GitHub] [airflow] mustafagok opened a new pull request #7136:
[AIRFLOW-6467] Make job_id parameter optional
mustafagok opened a new pull request #7136: [AIRFLOW-6467] Make job_id parameter optional
URL: https://github.com/apache/airflow/pull/7136
job_id parameter should be optional because it can be passed in json(dict) parameter.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7136:
[AIRFLOW-6536] Make job_id parameter optional
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7136: [AIRFLOW-6536] Make job_id parameter optional
URL: https://github.com/apache/airflow/pull/7136#issuecomment-573326191
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=h1) Report
> Merging [#7136](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7136 +/- ##
==========================================
- Coverage 85.24% 84.95% -0.29%
==========================================
Files 683 683
Lines 39155 39155
==========================================
- Hits 33378 33266 -112
- Misses 5777 5889 +112
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/operators/databricks\_operator.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhYnJpY2tzX29wZXJhdG9yLnB5) | `92.24% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=footer). Last update [a676f15...f69ea52](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7136: [AIRFLOW-6536] Make
job_id parameter optional
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7136: [AIRFLOW-6536] Make job_id parameter optional
URL: https://github.com/apache/airflow/pull/7136#issuecomment-573357010
> Actually there are some tests in the test_databricks_operator.py file:
> line 278:
> `test_init_with_json()` method (already updated in this PR) the job_id is not passed directly, and it is in the json dict in this test.
> Does it like the "one with the default param from json" or what kind of test should I implement other than this?
> line 267:
> `test_init_with_named_parameters()` job_id is not in the json, it passed directly.
That's a very good point :). I missed this test entirely. It's good to go !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7136:
[AIRFLOW-6536] Make job_id parameter optional
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7136: [AIRFLOW-6536] Make job_id parameter optional
URL: https://github.com/apache/airflow/pull/7136#issuecomment-573326191
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=h1) Report
> Merging [#7136](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7136 +/- ##
==========================================
- Coverage 85.24% 84.96% -0.28%
==========================================
Files 683 683
Lines 39155 39155
==========================================
- Hits 33378 33269 -109
- Misses 5777 5886 +109
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/operators/databricks\_operator.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhYnJpY2tzX29wZXJhdG9yLnB5) | `92.24% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88.38% <0%> (+0.38%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=footer). Last update [a676f15...f69ea52](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7136: [AIRFLOW-6536] Make
job_id parameter optional
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7136: [AIRFLOW-6536] Make job_id parameter optional
URL: https://github.com/apache/airflow/pull/7136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7136: [AIRFLOW-6536] Make
job_id parameter optional
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7136: [AIRFLOW-6536] Make job_id parameter optional
URL: https://github.com/apache/airflow/pull/7136#issuecomment-573326191
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=h1) Report
> Merging [#7136](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7136 +/- ##
==========================================
- Coverage 85.24% 84.95% -0.29%
==========================================
Files 683 683
Lines 39155 39155
==========================================
- Hits 33378 33266 -112
- Misses 5777 5889 +112
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/operators/databricks\_operator.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhYnJpY2tzX29wZXJhdG9yLnB5) | `92.24% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7136/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=footer). Last update [a676f15...f69ea52](https://codecov.io/gh/apache/airflow/pull/7136?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mustafagok commented on issue #7136: [AIRFLOW-6536] Make
job_id parameter optional
Posted by GitBox <gi...@apache.org>.
mustafagok commented on issue #7136: [AIRFLOW-6536] Make job_id parameter optional
URL: https://github.com/apache/airflow/pull/7136#issuecomment-573355737
Actually there are some tests in the test_databricks_operator.py file:
line 278:
`test_init_with_json()` method (already updated in this PR) the job_id is not passed directly, and it is in the json dict in this test.
Does it like the "one with the default param from json" or what kind of test should I implement other than this?
line 267:
`test_init_with_named_parameters()` job_id is not in the json, it passed directly. Also, in the all of the other tests except `test_init_with_json()`, job_id parameter passed because it was a required paremeter until now. So, does it like "the other with the param passed directly" or what kind of test should I implement other than this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services