You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/11 22:35:47 UTC
[GitHub] [helix] dasahcc opened a new pull request #1251: Add totalMessageReceivedCounter and decrepcate old totalMessageReceived
dasahcc opened a new pull request #1251:
URL: https://github.com/apache/helix/pull/1251
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
fixes #1249
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
Currently we should have counter type for totalMessageReceived but did not make it correct.
To fix this, we should have the a new counter metrics instead of directly changing the metrics for smooth migration.
### Tests
- [ ] The following tests are written for this issue:
- [ ] The following is the result of the "mvn test" command on the appropriate module:
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestWagedRebalance.testChangeIdealState:303->validate:646 expected:<true> but was:<false>
[INFO]
[ERROR] Tests run: 1163, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:22 h
[INFO] Finished at: 2020-08-11T14:56:32-07:00
[INFO] Final Memory: 32M/1106M
[INFO] ------------------------------------------------------------------------
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 58.931 s - in org.apache.helix.integration.rebalancer.WagedRebalancer.TestWagedRebalance
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:05 min
[INFO] Finished at: 2020-08-11T15:35:08-07:00
[INFO] Final Memory: 32M/1113M
[INFO] ------------------------------------------------------------------------
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc merged pull request #1251: Add totalMessageReceivedCounter and decrepcate old totalMessageReceived
Posted by GitBox <gi...@apache.org>.
dasahcc merged pull request #1251:
URL: https://github.com/apache/helix/pull/1251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1251: Add totalMessageReceivedCounter and decrepcate old totalMessageReceived
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1251:
URL: https://github.com/apache/helix/pull/1251#discussion_r469049584
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java
##########
@@ -71,8 +71,9 @@
private SimpleDynamicMetric<Long> _successTopStateHandoffCounter;
private SimpleDynamicMetric<Long> _failedTopStateHandoffCounter;
private SimpleDynamicMetric<Long> _maxSinglePartitionTopStateHandoffDuration;
- private SimpleDynamicMetric<Long> _totalMessageReceived;
-
+ @Deprecated
+ private SimpleDynamicMetric<Long> _totalMessageReceived; // This should be counter but it is not now
Review comment:
Nit: I think it would be good to add here why this needs to be a counter. We could add something like:
Because this is a metric indicating a "total" count (a.k.a. ever-increasing) value, we want to make sure this metric is a counter. If a gauge is used, the metric might get reset upon a controller switch, which won't be ever-increasing.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc commented on pull request #1251: Add totalMessageReceivedCounter and decrepcate old totalMessageReceived
Posted by GitBox <gi...@apache.org>.
dasahcc commented on pull request #1251:
URL: https://github.com/apache/helix/pull/1251#issuecomment-673025361
This PR is ready to be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc commented on a change in pull request #1251: Add totalMessageReceivedCounter and decrepcate old totalMessageReceived
Posted by GitBox <gi...@apache.org>.
dasahcc commented on a change in pull request #1251:
URL: https://github.com/apache/helix/pull/1251#discussion_r469440929
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java
##########
@@ -71,8 +71,9 @@
private SimpleDynamicMetric<Long> _successTopStateHandoffCounter;
private SimpleDynamicMetric<Long> _failedTopStateHandoffCounter;
private SimpleDynamicMetric<Long> _maxSinglePartitionTopStateHandoffDuration;
- private SimpleDynamicMetric<Long> _totalMessageReceived;
-
+ @Deprecated
+ private SimpleDynamicMetric<Long> _totalMessageReceived; // This should be counter but it is not now
Review comment:
Sure. Let me add the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org