You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by nn...@apache.org on 2014/11/19 23:55:38 UTC

mesos git commit: Removed trailing diff/ from review line in commit message.

Repository: mesos
Updated Branches:
  refs/heads/master 66e3d0633 -> 822738826


Removed trailing diff/ from review line in commit message.

Review: https://reviews.apache.org/r/28205


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/82273882
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/82273882
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/82273882

Branch: refs/heads/master
Commit: 82273882646654f77aad757c2e9b09cd42204b42
Parents: 66e3d06
Author: Joris Van Remoortere <jo...@gmail.com>
Authored: Wed Nov 19 14:53:11 2014 -0800
Committer: Niklas Q. Nielsen <ni...@mesosphere.io>
Committed: Wed Nov 19 14:53:11 2014 -0800

----------------------------------------------------------------------
 support/post-reviews.py | 6 ++++++
 1 file changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/82273882/support/post-reviews.py
----------------------------------------------------------------------
diff --git a/support/post-reviews.py b/support/post-reviews.py
index 33c95fa..c759799 100755
--- a/support/post-reviews.py
+++ b/support/post-reviews.py
@@ -217,6 +217,12 @@ for i in range(len(shas)):
     # The second to the last line of output in rbt is the review url.
     url = lines[len(lines) - 2] if 'rbt' in post_review \
         else lines[len(lines) - 1]
+
+    # Using rbt >= 0.6.3 on Linux prints out two URLs where the second
+    # one has /diff/ at the end. We want to remove this so that a
+    # subsequent call to post-reviews does not fail when looking up
+    # the reviewboard entry to edit.
+    url = url.replace('diff/','')
     url = url.strip('/')
 
     # Construct new commit message.