You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sowmya Krishnan <so...@citrix.com> on 2013/08/28 19:59:27 UTC
Review Request 13889: CLOUDSTACK-4487: Add Netscaler service provider if not
already present
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13889/
-----------------------------------------------------------
Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
Bugs: CLOUDSTACK-4487
Repository: cloudstack-git
Description
-------
For a brand new set up, Netscaler service provider won't be present by defualt.
Fixed the same in common.py.
Diffs
-----
tools/marvin/marvin/integration/lib/common.py f27e87d
Diff: https://reviews.apache.org/r/13889/diff/
Testing
-------
Tested on both new MS and an existing one.
Thanks,
Sowmya Krishnan
Re: Review Request 13889: CLOUDSTACK-4487: Add Netscaler service provider if
not already present
Posted by venkata swamy babu budumuru <ve...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13889/#review25928
-----------------------------------------------------------
Ship it!
Ship It!
- venkata swamy babu budumuru
On Aug. 28, 2013, 5:59 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13889/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 5:59 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4487
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For a brand new set up, Netscaler service provider won't be present by defualt.
> Fixed the same in common.py.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py f27e87d
>
> Diff: https://reviews.apache.org/r/13889/diff/
>
>
> Testing
> -------
>
> Tested on both new MS and an existing one.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>
Re: Review Request 13889: CLOUDSTACK-4487: Add Netscaler service provider if
not already present
Posted by Rayees Namathponnan <ra...@citrix.com>.
> On Aug. 29, 2013, 4:33 a.m., Prasanna Santhanam wrote:
> > The NetScaler provider is not different from any other provider and the test should not enable/disable it unless that's the test itself. The deployment configuration would need to be done differently. The providers required for a deployment should be enabled prior to the test run. This is the same case as deploying a basic zone. We don't configure the security group provider in the test, it just becomes part of the marvin deployment configuration.
> >
> > eg: In the case of advanced zone with security groups (setup/dev/advancedsg.cfg) you have the following section. deployDataCenter.py configures and enables the provider for you.
> >
> > "providers": [
> > {
> > "broadcastdomainrange": "ZONE",
> > "name": "VirtualRouter"
> > },
> > {
> > "broadcastdomainrange": "ZONE",
> > "name": "SecurityGroupProvider"
> > }
> > ],
Prasanna - Can we enable NetScaler as external device without adding any device in marvin config file ?
like
"providers": [
{
"broadcastdomainrange": "ZONE",
"name": "VirtualRouter"
},
{
"broadcastdomainrange": "ZONE",
"name": "SecurityGroupProvider"
}
{
"broadcastdomainrange": "ZONE",
"name": "Netscaler"
}
- Rayees
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13889/#review25707
-----------------------------------------------------------
On Aug. 28, 2013, 5:59 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13889/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 5:59 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4487
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For a brand new set up, Netscaler service provider won't be present by defualt.
> Fixed the same in common.py.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py f27e87d
>
> Diff: https://reviews.apache.org/r/13889/diff/
>
>
> Testing
> -------
>
> Tested on both new MS and an existing one.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>
Re: Review Request 13889: CLOUDSTACK-4487: Add Netscaler service provider if
not already present
Posted by Rayees Namathponnan <ra...@citrix.com>.
> On Aug. 29, 2013, 4:33 a.m., Prasanna Santhanam wrote:
> > The NetScaler provider is not different from any other provider and the test should not enable/disable it unless that's the test itself. The deployment configuration would need to be done differently. The providers required for a deployment should be enabled prior to the test run. This is the same case as deploying a basic zone. We don't configure the security group provider in the test, it just becomes part of the marvin deployment configuration.
> >
> > eg: In the case of advanced zone with security groups (setup/dev/advancedsg.cfg) you have the following section. deployDataCenter.py configures and enables the provider for you.
> >
> > "providers": [
> > {
> > "broadcastdomainrange": "ZONE",
> > "name": "VirtualRouter"
> > },
> > {
> > "broadcastdomainrange": "ZONE",
> > "name": "SecurityGroupProvider"
> > }
> > ],
>
> Rayees Namathponnan wrote:
> Prasanna - Can we enable NetScaler as external device without adding any device in marvin config file ?
>
> like
>
> "providers": [
> {
> "broadcastdomainrange": "ZONE",
> "name": "VirtualRouter"
> },
> {
> "broadcastdomainrange": "ZONE",
> "name": "SecurityGroupProvider"
> }
> {
> "broadcastdomainrange": "ZONE",
> "name": "Netscaler"
> }
>
>
>
> Prasanna Santhanam wrote:
> Yes - this will configure the provider and allow you to add a device. The test takes care of the addition of the device.
>
> Rayees Namathponnan wrote:
> OK, then i will try; please hold on for merging this patch
>
>
I tried to create setup as per Prasanna's suggestion, but i cannot setup env with below config in marvin config file
"providers": [
{
"broadcastdomainrange": "ZONE",
"name": "VirtualRouter"
},
{
"broadcastdomainrange": "ZONE",
"name": "SecurityGroupProvider"
}
{
"broadcastdomainrange": "ZONE",
"name": "Netscaler"
}
- Rayees
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13889/#review25707
-----------------------------------------------------------
On Aug. 28, 2013, 5:59 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13889/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 5:59 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4487
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For a brand new set up, Netscaler service provider won't be present by defualt.
> Fixed the same in common.py.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py f27e87d
>
> Diff: https://reviews.apache.org/r/13889/diff/
>
>
> Testing
> -------
>
> Tested on both new MS and an existing one.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>
Re: Review Request 13889: CLOUDSTACK-4487: Add Netscaler service provider if
not already present
Posted by Rayees Namathponnan <ra...@citrix.com>.
> On Aug. 29, 2013, 4:33 a.m., Prasanna Santhanam wrote:
> > The NetScaler provider is not different from any other provider and the test should not enable/disable it unless that's the test itself. The deployment configuration would need to be done differently. The providers required for a deployment should be enabled prior to the test run. This is the same case as deploying a basic zone. We don't configure the security group provider in the test, it just becomes part of the marvin deployment configuration.
> >
> > eg: In the case of advanced zone with security groups (setup/dev/advancedsg.cfg) you have the following section. deployDataCenter.py configures and enables the provider for you.
> >
> > "providers": [
> > {
> > "broadcastdomainrange": "ZONE",
> > "name": "VirtualRouter"
> > },
> > {
> > "broadcastdomainrange": "ZONE",
> > "name": "SecurityGroupProvider"
> > }
> > ],
>
> Rayees Namathponnan wrote:
> Prasanna - Can we enable NetScaler as external device without adding any device in marvin config file ?
>
> like
>
> "providers": [
> {
> "broadcastdomainrange": "ZONE",
> "name": "VirtualRouter"
> },
> {
> "broadcastdomainrange": "ZONE",
> "name": "SecurityGroupProvider"
> }
> {
> "broadcastdomainrange": "ZONE",
> "name": "Netscaler"
> }
>
>
>
> Prasanna Santhanam wrote:
> Yes - this will configure the provider and allow you to add a device. The test takes care of the addition of the device.
OK, then i will try; please hold on for merging this patch
- Rayees
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13889/#review25707
-----------------------------------------------------------
On Aug. 28, 2013, 5:59 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13889/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 5:59 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4487
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For a brand new set up, Netscaler service provider won't be present by defualt.
> Fixed the same in common.py.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py f27e87d
>
> Diff: https://reviews.apache.org/r/13889/diff/
>
>
> Testing
> -------
>
> Tested on both new MS and an existing one.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>
Re: Review Request 13889: CLOUDSTACK-4487: Add Netscaler service provider if
not already present
Posted by Prasanna Santhanam <ts...@apache.org>.
> On Aug. 29, 2013, 4:33 a.m., Prasanna Santhanam wrote:
> > The NetScaler provider is not different from any other provider and the test should not enable/disable it unless that's the test itself. The deployment configuration would need to be done differently. The providers required for a deployment should be enabled prior to the test run. This is the same case as deploying a basic zone. We don't configure the security group provider in the test, it just becomes part of the marvin deployment configuration.
> >
> > eg: In the case of advanced zone with security groups (setup/dev/advancedsg.cfg) you have the following section. deployDataCenter.py configures and enables the provider for you.
> >
> > "providers": [
> > {
> > "broadcastdomainrange": "ZONE",
> > "name": "VirtualRouter"
> > },
> > {
> > "broadcastdomainrange": "ZONE",
> > "name": "SecurityGroupProvider"
> > }
> > ],
>
> Rayees Namathponnan wrote:
> Prasanna - Can we enable NetScaler as external device without adding any device in marvin config file ?
>
> like
>
> "providers": [
> {
> "broadcastdomainrange": "ZONE",
> "name": "VirtualRouter"
> },
> {
> "broadcastdomainrange": "ZONE",
> "name": "SecurityGroupProvider"
> }
> {
> "broadcastdomainrange": "ZONE",
> "name": "Netscaler"
> }
>
>
Yes - this will configure the provider and allow you to add a device. The test takes care of the addition of the device.
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13889/#review25707
-----------------------------------------------------------
On Aug. 28, 2013, 5:59 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13889/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 5:59 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4487
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For a brand new set up, Netscaler service provider won't be present by defualt.
> Fixed the same in common.py.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py f27e87d
>
> Diff: https://reviews.apache.org/r/13889/diff/
>
>
> Testing
> -------
>
> Tested on both new MS and an existing one.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>
Re: Review Request 13889: CLOUDSTACK-4487: Add Netscaler service provider if
not already present
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13889/#review25707
-----------------------------------------------------------
The NetScaler provider is not different from any other provider and the test should not enable/disable it unless that's the test itself. The deployment configuration would need to be done differently. The providers required for a deployment should be enabled prior to the test run. This is the same case as deploying a basic zone. We don't configure the security group provider in the test, it just becomes part of the marvin deployment configuration.
eg: In the case of advanced zone with security groups (setup/dev/advancedsg.cfg) you have the following section. deployDataCenter.py configures and enables the provider for you.
"providers": [
{
"broadcastdomainrange": "ZONE",
"name": "VirtualRouter"
},
{
"broadcastdomainrange": "ZONE",
"name": "SecurityGroupProvider"
}
],
- Prasanna Santhanam
On Aug. 28, 2013, 5:59 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13889/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 5:59 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4487
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For a brand new set up, Netscaler service provider won't be present by defualt.
> Fixed the same in common.py.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py f27e87d
>
> Diff: https://reviews.apache.org/r/13889/diff/
>
>
> Testing
> -------
>
> Tested on both new MS and an existing one.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>
Re: Review Request 13889: CLOUDSTACK-4487: Add Netscaler service provider if
not already present
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13889/#review25930
-----------------------------------------------------------
Commit 8b5cb374b93a1821216f8fba9fd5e908905a3ce8 in branch refs/heads/master from Sowmya Krishnan
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8b5cb37 ]
CLOUDSTACK-4487 Fix adding Netscaler service provider if not already done
Signed-off-by: venkataswamybabu budumuru <ve...@citrix.com>
(cherry picked from commit c1ea61a0e736ce626c0d1f21e90cf9aaf7f89964)
- ASF Subversion and Git Services
On Aug. 28, 2013, 5:59 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13889/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 5:59 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4487
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For a brand new set up, Netscaler service provider won't be present by defualt.
> Fixed the same in common.py.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py f27e87d
>
> Diff: https://reviews.apache.org/r/13889/diff/
>
>
> Testing
> -------
>
> Tested on both new MS and an existing one.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>
Re: Review Request 13889: CLOUDSTACK-4487: Add Netscaler service provider if
not already present
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13889/#review25929
-----------------------------------------------------------
Commit c1ea61a0e736ce626c0d1f21e90cf9aaf7f89964 in branch refs/heads/4.2-forward from Sowmya Krishnan
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c1ea61a ]
CLOUDSTACK-4487 Fix adding Netscaler service provider if not already done
Signed-off-by: venkataswamybabu budumuru <ve...@citrix.com>
- ASF Subversion and Git Services
On Aug. 28, 2013, 5:59 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13889/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 5:59 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4487
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For a brand new set up, Netscaler service provider won't be present by defualt.
> Fixed the same in common.py.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/common.py f27e87d
>
> Diff: https://reviews.apache.org/r/13889/diff/
>
>
> Testing
> -------
>
> Tested on both new MS and an existing one.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>