You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/16 13:11:24 UTC

[GitHub] [bookkeeper] eolivelli commented on pull request #2796: Issue 2795: Bookkeeper upgrade using Bookie ID may fail due to cookie mismatch

eolivelli commented on pull request #2796:
URL: https://github.com/apache/bookkeeper/pull/2796#issuecomment-920887677


   This change makes sense to me.
   
   The upgrade story for enabling BookieID is to compute the same BookieID as it is written in the bookie, like you did in Pravega, is this correct ?
   
   We should write this somewhere in the docs (not in the scope of this PR)
   
   In order to finalise the patch we have to add a unit test, probably a unit test about this method that you changed is enough.
   A test that shows how to switch to BookieID will be also very good


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org