You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/11/19 15:52:05 UTC
Review Request 69397: Used high-level `FrameworkInfo` validation
function in tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69397/
-----------------------------------------------------------
Review request for mesos and Meng Zhu.
Bugs: MESOS-8470
https://issues.apache.org/jira/browse/MESOS-8470
Repository: mesos
Description
-------
This patch replaces uses of `framework::validateRoles` with the more
high-level `framework::validate`. Since e.g., the master invokes
`validate` instead of directly invoking `validateRoles` this ensures
that our tests more closely match master behavior, and helps
preventing that we test code which is not invoked in reality.
Diffs
-----
src/tests/master_validation_tests.cpp aa7c8f70c09459be32c6c415497e95fcdc218efd
Diff: https://reviews.apache.org/r/69397/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69397: Used high-level `FrameworkInfo` validation
function in tests.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69397/#review210772
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Nov. 19, 2018, 7:52 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69397/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2018, 7:52 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-8470
> https://issues.apache.org/jira/browse/MESOS-8470
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch replaces uses of `framework::validateRoles` with the more
> high-level `framework::validate`. Since e.g., the master invokes
> `validate` instead of directly invoking `validateRoles` this ensures
> that our tests more closely match master behavior, and helps
> preventing that we test code which is not invoked in reality.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp aa7c8f70c09459be32c6c415497e95fcdc218efd
>
>
> Diff: https://reviews.apache.org/r/69397/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69397: Used high-level `FrameworkInfo` validation
function in tests.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69397/#review211211
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Dec. 11, 2018, 1:48 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69397/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2018, 1:48 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9469
> https://issues.apache.org/jira/browse/MESOS-9469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch replaces uses of `framework::validateRoles` with the more
> high-level `framework::validate`. Since e.g., the master invokes
> `validate` instead of directly invoking `validateRoles` this ensures
> that our tests more closely match master behavior, and helps
> preventing that we test code which is not invoked in reality.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 3aa7b2a2dcaf054ad2a67c52462493c97b7178c4
>
>
> Diff: https://reviews.apache.org/r/69397/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69397: Used high-level `FrameworkInfo` validation
function in tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69397/
-----------------------------------------------------------
(Updated Dec. 11, 2018, 2:48 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Bugs: MESOS-9469
https://issues.apache.org/jira/browse/MESOS-9469
Repository: mesos
Description
-------
This patch replaces uses of `framework::validateRoles` with the more
high-level `framework::validate`. Since e.g., the master invokes
`validate` instead of directly invoking `validateRoles` this ensures
that our tests more closely match master behavior, and helps
preventing that we test code which is not invoked in reality.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 3aa7b2a2dcaf054ad2a67c52462493c97b7178c4
Diff: https://reviews.apache.org/r/69397/diff/2/
Changes: https://reviews.apache.org/r/69397/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier