[GitHub] codelipenghui commented on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned

[GitBox <gi...@apache.org>]

codelipenghui commented on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned
URL: https://github.com/apache/pulsar/pull/3118#issuecomment-444334351
 
 
   @jai1 
   > I would suggest to modify UnAckedMessageTracker instead of creating a new class.
   
   Agree, i want to get some advice for two solutions(WheelTimer and TimePartition).
   
   >Change ConsumerConfig => setAckTimeout(time, timeunit, numOfSlots); // assert (numOfSlots >= 2);
   
   I think it's understandable use ticketDurationInMs instead of numOfSlots, ticketDurationInMs can directly express the deviation in time.
   
   >add new messages to list.get(0)
   On acktimeout redeliver list.get(list.size() - 1); and push messages down from i,e list.add(i + 1, list.get(i));
   
   we can save the tail reference of time partition, add message to the tail time partition and timer task work at head time partition
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services