You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2021/04/08 13:34:22 UTC

[GitHub] [karaf] jbonofre commented on a change in pull request #1343: [KARAF-7096] Ensure that RMIServerImpl_Stub contains correct rmiServerHost

jbonofre commented on a change in pull request #1343:
URL: https://github.com/apache/karaf/pull/1343#discussion_r609706165



##########
File path: management/server/src/main/java/org/apache/karaf/management/internal/Activator.java
##########
@@ -60,6 +60,8 @@
 
     private EventAdminLogger eventAdminLogger;
 
+    private String defaultRmiServerHostname;

Review comment:
       I would rather use a name like `originalRmiServerHostname` more than `default`. This field is more to store existing `java.rmi.server.hostname` (system property)  more than a default value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org