You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "efegokdemir (via GitHub)" <gi...@apache.org> on 2026/09/25 05:54:26 UTC
[PR] fix: name plugin report pages after goals [maven-plugin-tools]
efegokdemir opened a new pull request, #1217:
URL: https://github.com/apache/maven-plugin-tools/pull/1217
## Summary
Update per-goal plugin report pages to use the `{goal}-goal.html` naming convention requested in #949 while preserving compatibility for existing links.
## Changes
- Generate goal reports as `{goal}-goal.html`.
- Keep `{goal}-mojo.html` compatibility pages as redirects by default.
- Add `maven.plugin.report.generateLegacyMojoReports` to disable compatibility pages when desired.
- Update report links, documentation, annotations, and integration assertions.
## Testing
- `mvn -pl maven-plugin-report-plugin -am -DskipITs -Drat.skip -Dspotless.skip=true verify` — passed.
- Targeted `plugin-report` integration build generated both `*-goal.html` pages and legacy redirect pages. Its Groovy verification hook is blocked on this machine by the installed Java 27 runtime (`Unsupported class file major version 71`).
- `git diff --check` — passed.
## Notes
- The complete diff was reviewed by the submitter; AI assistance was used during implementation.
- No overlapping open PR was found for #949 or the `goal.html` change.
Fixes #949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: name plugin report pages after goals [maven-plugin-tools]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on code in PR #1217:
URL: https://github.com/apache/maven-plugin-tools/pull/1217#discussion_r4294370858
##########
maven-plugin-report-plugin/src/it/plugin-report-400/verify.groovy:
##########
@@ -17,8 +17,8 @@
* under the License.
*/
-assert new File( basedir, 'target/site/noop-mojo.html' ).isFile()
-assert new File( basedir, 'target/site/report-mojo.html' ).isFile()
+assert new File( basedir, 'target/site/noop-goal.html' ).isFile()
+assert new File( basedir, 'target/site/report-goal.html' ).isFile()
Review Comment:
💡 **Missing redirect assertions (not blocking)**
The `plugin-report` IT now asserts that the legacy `-mojo.html` redirect files exist and point to the new `-goal.html` pages (e.g. `assert new File(basedir, 'target/site/noop-mojo.html').text.contains('noop-goal.html')`). This IT only checks that the new `-goal.html` files exist but doesn't verify the redirect files are created.
Consider adding similar redirect assertions here for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: name plugin report pages after goals [maven-plugin-tools]
Posted by "gnodet-bot (via GitHub) via issues" <is...@maven.apache.org>.
gnodet-bot commented on code in PR #1217:
URL: https://github.com/apache/maven-plugin-tools/pull/1217#discussion_r4505381844
##########
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##########
@@ -82,6 +83,14 @@ public class PluginReport extends AbstractMavenReport {
@Parameter(defaultValue = "false", property = "maven.plugin.report.skip")
private boolean skip;
+ /**
+ * Set this to {@code false} to stop generating compatibility pages using the legacy {@code -mojo.html} suffix.
+ *
+ * @since 4.0.0
+ */
+ @Parameter(defaultValue = "true", property = "maven.plugin.report.generateLegacyMojoReports")
+ private boolean generateLegacyMojoReports;
Review Comment:
⚠️ **Missing IT for `generateLegacyMojoReports=false`**
This new parameter is never exercised with `false` in any integration test. The ITs only run with the default (`true`), so the branch that suppresses redirect file generation is completely untested.
Add an IT (e.g. `plugin-report-no-compat`) that sets this to `false` via `invoker.properties` or plugin configuration, and verifies:
1. `{goal}-goal.html` exists.
2. `{goal}-mojo.html` does **not** exist (no redirect generated).
Without this, a regression in the flag's injection or the conditional guard would go undetected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org