[GitHub] [incubator-superset] semantiDan commented on a change in pull request #8003: Added better display of NULL values in FilterableTable (as in SQL Lab Results)

[GitBox <gi...@apache.org>]

semantiDan commented on a change in pull request #8003: Added better display of NULL values in FilterableTable (as in SQL Lab Results)
URL: https://github.com/apache/incubator-superset/pull/8003#discussion_r311642286
 
 

 ##########
 File path: superset/assets/src/components/FilterableTable/FilterableTable.jsx
 ##########
 @@ -173,13 +174,19 @@ export default class FilterableTable extends PureComponent {
   }
 
   getCellContent({ cellData, columnKey }) {
-    const content = String(cellData);
+    let content = String(cellData);
 
 Review comment:
   Per your recommendation, I will add the following code at the beginning before the rest of the logic:
   ```
       if (cellData === null) {
         return (
           <i className="null-cell">
             NULL
           </i>
         );
       }
   ```
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org