[GitHub] [trafficserver] zwoop commented on pull request #8052: Perf: Introduce TSMimeHdrFieldFast* APIs

[GitBox <gi...@apache.org>]

zwoop commented on pull request #8052:
URL: https://github.com/apache/trafficserver/pull/8052#issuecomment-880079084


   I like this, sort of :-). My suggestion would be that rather than adding set of new TS*Fast*() APIs, we modify the existing APIs. Yes, this breaks compatibility, but has several benefits:
   
   1. It's a hell of a lot more obvious when and how to use the new flavor of these APIs
   2. It avoids additional APIs that needs to be chosen carefully
   
   As such, I suggest we modify the new APIs like this:
   
   ```
   tsapi TSMLoc TSMimeHdrFieldFind(TSMBuffer bufp, TSMLoc hdr, const char *name, int length, TSMLoc *locp);
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org