[GitHub] marcoabreu commented on a change in pull request #11875: fix flaky test: test_broadcast_binary_op

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #11875: fix flaky test: test_broadcast_binary_op
URL: https://github.com/apache/incubator-mxnet/pull/11875#discussion_r211365055
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -1911,10 +1911,17 @@ def test_bdiv(a, b):
         check_binary_op_forward(c, lambda a, b: a / b, gen_broadcast_data, mx_nd_func=mx.nd.divide)
         check_binary_op_backward(c, lambda g_out, a, b: (g_out / b, - g_out * a / (b * b)), gen_broadcast_data)
 
-    def test_bmod(a, b):
+    def test_bmod(a_, b_):
 
 Review comment:
   Are you using a and a_ on purpose? It seems like sometimes you are using a and b, while other times you use a_ and b_

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services