You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Alex Blewitt <Al...@ioshq.com> on 2003/08/16 13:31:52 UTC
[PATCH] Updated JavaMail and Activation project files
Modified activation to be in separate geronimo-activation package
instead of geronimo-spec (to support easier refactoring into
commons-activation at a future stage).
Modified javamail to maintain relationship.
Alex.
Index: project.xml
===================================================================
RCS file:
/home/cvspublic/incubator-geronimo/specs/javamail/project.xml,v
retrieving revision 1.1
diff -u -r1.1 project.xml
--- project.xml 16 Aug 2003 01:55:47 -0000 1.1
+++ project.xml 16 Aug 2003 11:30:39 -0000
@@ -14,13 +14,13 @@
<siteDirectory></siteDirectory>
<distributionDirectory></distributionDirectory>
- <package>javax</package>
+ <package>javax.mail</package>
<currentVersion>DEV</currentVersion>
<!-- Module Dependencies -->
<dependencies>
<dependency>
- <groupId>geronimo-spec</groupId>
+ <groupId>geronimo-activation</groupId>
<artifactId>geronimo-spec-activation</artifactId>
<version>DEV</version>
</dependency>
Index: project.xml
===================================================================
RCS file:
/home/cvspublic/incubator-geronimo/specs/activation/project.xml,v
retrieving revision 1.1
diff -u -r1.1 project.xml
--- project.xml 16 Aug 2003 01:55:47 -0000 1.1
+++ project.xml 16 Aug 2003 11:28:05 -0000
@@ -7,14 +7,14 @@
<extend>${basedir}/../../etc/project.xml</extend>
<name>Geronimo :: Java Activation Framework Specification</name>
- <groupId>geronimo-spec</groupId>
+ <groupId>geronimo-activation</groupId>
<id>geronimo-spec-activation</id>
<shortDescription></shortDescription>
<description></description>
<siteDirectory></siteDirectory>
<distributionDirectory></distributionDirectory>
- <package>javax</package>
+ <package>javax.activation</package>
<currentVersion>DEV</currentVersion>
</project>
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Jason Dillon <ja...@coredevelopers.net>.
It is just easier for me personally to export the attachment and then
apply the patch.
--jason
On Saturday, August 16, 2003, at 06:50 PM, Alex Blewitt wrote:
> They were inlined text. It is undesirable to have them as text? In
> which case, I can attach as files.
>
> Alex.
>
> (PS Sent with Apple Mail, too :-)
>
> On Saturday, Aug 16, 2003, at 12:37 Europe/London, Jason Dillon wrote:
>
>> Are these attachments or inlined text? Could be Apple Mail is
>> mucking with this... :-(
>>
>> --jason
>>
>>
>> On Saturday, August 16, 2003, at 06:31 PM, Alex Blewitt wrote:
>>
>>> Modified activation to be in separate geronimo-activation package
>>> instead of geronimo-spec (to support easier refactoring into
>>> commons-activation at a future stage).
>>> Modified javamail to maintain relationship.
>>>
>>> Alex.
>>>
>>> Index: project.xml
>>> ===================================================================
>>> RCS file:
>>> /home/cvspublic/incubator-geronimo/specs/javamail/project.xml,v
>>> retrieving revision 1.1
>>> diff -u -r1.1 project.xml
>>> --- project.xml 16 Aug 2003 01:55:47 -0000 1.1
>>> +++ project.xml 16 Aug 2003 11:30:39 -0000
>>> @@ -14,13 +14,13 @@
>>> <siteDirectory></siteDirectory>
>>> <distributionDirectory></distributionDirectory>
>>>
>>> - <package>javax</package>
>>> + <package>javax.mail</package>
>>> <currentVersion>DEV</currentVersion>
>>>
>>> <!-- Module Dependencies -->
>>> <dependencies>
>>> <dependency>
>>> - <groupId>geronimo-spec</groupId>
>>> + <groupId>geronimo-activation</groupId>
>>> <artifactId>geronimo-spec-activation</artifactId>
>>> <version>DEV</version>
>>> </dependency>
>>>
>>>
>>> Index: project.xml
>>> ===================================================================
>>> RCS file:
>>> /home/cvspublic/incubator-geronimo/specs/activation/project.xml,v
>>> retrieving revision 1.1
>>> diff -u -r1.1 project.xml
>>> --- project.xml 16 Aug 2003 01:55:47 -0000 1.1
>>> +++ project.xml 16 Aug 2003 11:28:05 -0000
>>> @@ -7,14 +7,14 @@
>>> <extend>${basedir}/../../etc/project.xml</extend>
>>>
>>> <name>Geronimo :: Java Activation Framework Specification</name>
>>> - <groupId>geronimo-spec</groupId>
>>> + <groupId>geronimo-activation</groupId>
>>> <id>geronimo-spec-activation</id>
>>> <shortDescription></shortDescription>
>>> <description></description>
>>> <siteDirectory></siteDirectory>
>>> <distributionDirectory></distributionDirectory>
>>>
>>> - <package>javax</package>
>>> + <package>javax.activation</package>
>>> <currentVersion>DEV</currentVersion>
>>>
>>> </project>
>>>
>>
>
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Alex Blewitt <Al...@ioshq.com>.
They were inlined text. It is undesirable to have them as text? In
which case, I can attach as files.
Alex.
(PS Sent with Apple Mail, too :-)
On Saturday, Aug 16, 2003, at 12:37 Europe/London, Jason Dillon wrote:
> Are these attachments or inlined text? Could be Apple Mail is mucking
> with this... :-(
>
> --jason
>
>
> On Saturday, August 16, 2003, at 06:31 PM, Alex Blewitt wrote:
>
>> Modified activation to be in separate geronimo-activation package
>> instead of geronimo-spec (to support easier refactoring into
>> commons-activation at a future stage).
>> Modified javamail to maintain relationship.
>>
>> Alex.
>>
>> Index: project.xml
>> ===================================================================
>> RCS file:
>> /home/cvspublic/incubator-geronimo/specs/javamail/project.xml,v
>> retrieving revision 1.1
>> diff -u -r1.1 project.xml
>> --- project.xml 16 Aug 2003 01:55:47 -0000 1.1
>> +++ project.xml 16 Aug 2003 11:30:39 -0000
>> @@ -14,13 +14,13 @@
>> <siteDirectory></siteDirectory>
>> <distributionDirectory></distributionDirectory>
>>
>> - <package>javax</package>
>> + <package>javax.mail</package>
>> <currentVersion>DEV</currentVersion>
>>
>> <!-- Module Dependencies -->
>> <dependencies>
>> <dependency>
>> - <groupId>geronimo-spec</groupId>
>> + <groupId>geronimo-activation</groupId>
>> <artifactId>geronimo-spec-activation</artifactId>
>> <version>DEV</version>
>> </dependency>
>>
>>
>> Index: project.xml
>> ===================================================================
>> RCS file:
>> /home/cvspublic/incubator-geronimo/specs/activation/project.xml,v
>> retrieving revision 1.1
>> diff -u -r1.1 project.xml
>> --- project.xml 16 Aug 2003 01:55:47 -0000 1.1
>> +++ project.xml 16 Aug 2003 11:28:05 -0000
>> @@ -7,14 +7,14 @@
>> <extend>${basedir}/../../etc/project.xml</extend>
>>
>> <name>Geronimo :: Java Activation Framework Specification</name>
>> - <groupId>geronimo-spec</groupId>
>> + <groupId>geronimo-activation</groupId>
>> <id>geronimo-spec-activation</id>
>> <shortDescription></shortDescription>
>> <description></description>
>> <siteDirectory></siteDirectory>
>> <distributionDirectory></distributionDirectory>
>>
>> - <package>javax</package>
>> + <package>javax.activation</package>
>> <currentVersion>DEV</currentVersion>
>>
>> </project>
>>
>
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Jason Dillon <ja...@coredevelopers.net>.
Are these attachments or inlined text? Could be Apple Mail is mucking
with this... :-(
--jason
On Saturday, August 16, 2003, at 06:31 PM, Alex Blewitt wrote:
> Modified activation to be in separate geronimo-activation package
> instead of geronimo-spec (to support easier refactoring into
> commons-activation at a future stage).
> Modified javamail to maintain relationship.
>
> Alex.
>
> Index: project.xml
> ===================================================================
> RCS file:
> /home/cvspublic/incubator-geronimo/specs/javamail/project.xml,v
> retrieving revision 1.1
> diff -u -r1.1 project.xml
> --- project.xml 16 Aug 2003 01:55:47 -0000 1.1
> +++ project.xml 16 Aug 2003 11:30:39 -0000
> @@ -14,13 +14,13 @@
> <siteDirectory></siteDirectory>
> <distributionDirectory></distributionDirectory>
>
> - <package>javax</package>
> + <package>javax.mail</package>
> <currentVersion>DEV</currentVersion>
>
> <!-- Module Dependencies -->
> <dependencies>
> <dependency>
> - <groupId>geronimo-spec</groupId>
> + <groupId>geronimo-activation</groupId>
> <artifactId>geronimo-spec-activation</artifactId>
> <version>DEV</version>
> </dependency>
>
>
> Index: project.xml
> ===================================================================
> RCS file:
> /home/cvspublic/incubator-geronimo/specs/activation/project.xml,v
> retrieving revision 1.1
> diff -u -r1.1 project.xml
> --- project.xml 16 Aug 2003 01:55:47 -0000 1.1
> +++ project.xml 16 Aug 2003 11:28:05 -0000
> @@ -7,14 +7,14 @@
> <extend>${basedir}/../../etc/project.xml</extend>
>
> <name>Geronimo :: Java Activation Framework Specification</name>
> - <groupId>geronimo-spec</groupId>
> + <groupId>geronimo-activation</groupId>
> <id>geronimo-spec-activation</id>
> <shortDescription></shortDescription>
> <description></description>
> <siteDirectory></siteDirectory>
> <distributionDirectory></distributionDirectory>
>
> - <package>javax</package>
> + <package>javax.activation</package>
> <currentVersion>DEV</currentVersion>
>
> </project>
>
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Alex Blewitt <Al...@ioshq.com>.
On Saturday, Aug 16, 2003, at 13:57 Europe/London, Jason Dillon wrote:
>> I'm happy for them to both be in the geronimo-spec, but as it stands
>> ATM the JavaMail one isn't. It's defined in its own, so can you
>> change it to ensure that both the JavaMail and Activation are in the
>> right places as you want them?
>
> I do not follow.
Sorry, I mean that (in the repository) javamail's project.xml file had
<groupId>geronimo-javamail<groupId>
<id>geronimo-spec-javamail</id>
but now it's been updated to
<groupId>geronimo-spec</groupId>
<id>geronimo-spec-javamail</id>
which was what I was trying to say needed to be changed. Looks like
you'd already picked that up, though.
Alex.
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Jason Dillon <ja...@coredevelopers.net>.
> I'm happy for them to both be in the geronimo-spec, but as it stands
> ATM the JavaMail one isn't. It's defined in its own, so can you change
> it to ensure that both the JavaMail and Activation are in the right
> places as you want them?
I do not follow.
--jason
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Alex Blewitt <Al...@ioshq.com>.
>> So I wasn't doing it just because they were their own modules, but
>> because of the reusability of those generic components. I'd concur
>> that you wouldn't want (say) javax.servlet or javax.ejb outside of a
>> J2EE server, but JavaMail you might ...
>
> They are already in there own modules and it does not matter to an
> external project what the end id of the dependency is. Putting the
> JavaMail spec into the geronimo-javamail group does not make it any
> more (or less) difficult for a project to depend on it. So for now
> everything under specs/ gets released in the geronimo-spec group.
>
> Finally, I am not in favor of moving the JavaMail specs to Commons at
> this time and I believe that we should not even be thinking about it
> right now. Sure someday another project might be created to hold all
> sorts of ASL impls of Sun specs, that does not mean that Commons will
> be the place.
>
> It is too early to be thinking about moving anything to another
> project, so please lets drop it.
I'm happy for them to both be in the geronimo-spec, but as it stands
ATM the JavaMail one isn't. It's defined in its own, so can you change
it to ensure that both the JavaMail and Activation are in the right
places as you want them?
Thanks,
Alex.
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Jason Dillon <ja...@coredevelopers.net>.
> The initial build put the geronimo-javamail in its own holder,
> presumably so that it would be easier to migrate into commons-javamail
> at a later stage.
Changing the group id of the artifact is minor and does not make it any
more difficult to migrate. Again lets not worry about migration... it
is way to early to think about this.
> At present, though, the situation is less than ideal: activation ->
> geronimo-spec and javamail -> geronimo-javamail. That means you'd need
> both the geronimo-spec and geronimo-javamail in order to use the
> JavaMail APIs.
What? You referring to groups when you should be referring to artifacts
as dependencies. Groups only serve as organizational tools.
> So I wasn't doing it just because they were their own modules, but
> because of the reusability of those generic components. I'd concur
> that you wouldn't want (say) javax.servlet or javax.ejb outside of a
> J2EE server, but JavaMail you might ...
They are already in there own modules and it does not matter to an
external project what the end id of the dependency is. Putting the
JavaMail spec into the geronimo-javamail group does not make it any
more (or less) difficult for a project to depend on it. So for now
everything under specs/ gets released in the geronimo-spec group.
Finally, I am not in favor of moving the JavaMail specs to Commons at
this time and I believe that we should not even be thinking about it
right now. Sure someday another project might be created to hold all
sorts of ASL impls of Sun specs, that does not mean that Commons will
be the place.
It is too early to be thinking about moving anything to another
project, so please lets drop it.
--jason
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Alex Blewitt <Al...@ioshq.com>.
The initial build put the geronimo-javamail in its own holder,
presumably so that it would be easier to migrate into commons-javamail
at a later stage.
Either they need to go into geronimo-javamail and geronimo-activation,
or they both need to go into geronimo-spec.
There has also been interest in the JavaMail APIs from the James end,
which was why I think it was originally put into its own artifact
group; thus, people who want to experiment with JavaMail on its own can
do so.
At present, though, the situation is less than ideal: activation ->
geronimo-spec and javamail -> geronimo-javamail. That means you'd need
both the geronimo-spec and geronimo-javamail in order to use the
JavaMail APIs.
So I wasn't doing it just because they were their own modules, but
because of the reusability of those generic components. I'd concur that
you wouldn't want (say) javax.servlet or javax.ejb outside of a J2EE
server, but JavaMail you might ...
Alex.
On Saturday, Aug 16, 2003, at 13:17 Europe/London, Jason Dillon wrote:
> I am not in favor of creating artifact groups for each module or spec,
> but only for high-level organization. Specs go into the geronimo-spec
> group and everything else goes into the geronimo group.
>
> --jason
>
>
> On Saturday, August 16, 2003, at 06:59 PM, Alex Blewitt wrote:
>
>>
>> On Saturday, Aug 16, 2003, at 12:52 Europe/London, Jason Dillon wrote:
>>
>>> Please, lets not worry about moving things out of geronimo at this
>>> time.
>>
>> I wasn't worrying about moving them out now, but I don't think it's
>> sensible for geronimo-javamail to be built as a separate unit that
>> then depends on geronimo-spec. I think it's sensible to move it out
>> to a separate build in any case, or failing that fold the
>> geronimo-javamail back into the geronimo-spec module (which I would
>> not prefer).
>>
>> Alex.
>>
>>>> Modified activation to be in separate geronimo-activation package
>>>> instead of geronimo-spec (to support easier refactoring into
>>>> commons-activation at a future stage).
>>>> Modified javamail to maintain relationship.
>>
>>
>
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Jason Dillon <ja...@coredevelopers.net>.
I am not in favor of creating artifact groups for each module or spec,
but only for high-level organization. Specs go into the geronimo-spec
group and everything else goes into the geronimo group.
--jason
On Saturday, August 16, 2003, at 06:59 PM, Alex Blewitt wrote:
>
> On Saturday, Aug 16, 2003, at 12:52 Europe/London, Jason Dillon wrote:
>
>> Please, lets not worry about moving things out of geronimo at this
>> time.
>
> I wasn't worrying about moving them out now, but I don't think it's
> sensible for geronimo-javamail to be built as a separate unit that
> then depends on geronimo-spec. I think it's sensible to move it out to
> a separate build in any case, or failing that fold the
> geronimo-javamail back into the geronimo-spec module (which I would
> not prefer).
>
> Alex.
>
>>> Modified activation to be in separate geronimo-activation package
>>> instead of geronimo-spec (to support easier refactoring into
>>> commons-activation at a future stage).
>>> Modified javamail to maintain relationship.
>
>
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Alex Blewitt <Al...@ioshq.com>.
On Saturday, Aug 16, 2003, at 12:52 Europe/London, Jason Dillon wrote:
> Please, lets not worry about moving things out of geronimo at this
> time.
I wasn't worrying about moving them out now, but I don't think it's
sensible for geronimo-javamail to be built as a separate unit that then
depends on geronimo-spec. I think it's sensible to move it out to a
separate build in any case, or failing that fold the geronimo-javamail
back into the geronimo-spec module (which I would not prefer).
Alex.
>> Modified activation to be in separate geronimo-activation package
>> instead of geronimo-spec (to support easier refactoring into
>> commons-activation at a future stage).
>> Modified javamail to maintain relationship.
Re: [PATCH] Updated JavaMail and Activation project files
Posted by Jason Dillon <ja...@coredevelopers.net>.
Please, lets not worry about moving things out of geronimo at this time.
--jason
On Saturday, August 16, 2003, at 06:31 PM, Alex Blewitt wrote:
> Modified activation to be in separate geronimo-activation package
> instead of geronimo-spec (to support easier refactoring into
> commons-activation at a future stage).
> Modified javamail to maintain relationship.
>
> Alex.
>
> Index: project.xml
> ===================================================================
> RCS file:
> /home/cvspublic/incubator-geronimo/specs/javamail/project.xml,v
> retrieving revision 1.1
> diff -u -r1.1 project.xml
> --- project.xml 16 Aug 2003 01:55:47 -0000 1.1
> +++ project.xml 16 Aug 2003 11:30:39 -0000
> @@ -14,13 +14,13 @@
> <siteDirectory></siteDirectory>
> <distributionDirectory></distributionDirectory>
>
> - <package>javax</package>
> + <package>javax.mail</package>
> <currentVersion>DEV</currentVersion>
>
> <!-- Module Dependencies -->
> <dependencies>
> <dependency>
> - <groupId>geronimo-spec</groupId>
> + <groupId>geronimo-activation</groupId>
> <artifactId>geronimo-spec-activation</artifactId>
> <version>DEV</version>
> </dependency>
>
>
> Index: project.xml
> ===================================================================
> RCS file:
> /home/cvspublic/incubator-geronimo/specs/activation/project.xml,v
> retrieving revision 1.1
> diff -u -r1.1 project.xml
> --- project.xml 16 Aug 2003 01:55:47 -0000 1.1
> +++ project.xml 16 Aug 2003 11:28:05 -0000
> @@ -7,14 +7,14 @@
> <extend>${basedir}/../../etc/project.xml</extend>
>
> <name>Geronimo :: Java Activation Framework Specification</name>
> - <groupId>geronimo-spec</groupId>
> + <groupId>geronimo-activation</groupId>
> <id>geronimo-spec-activation</id>
> <shortDescription></shortDescription>
> <description></description>
> <siteDirectory></siteDirectory>
> <distributionDirectory></distributionDirectory>
>
> - <package>javax</package>
> + <package>javax.activation</package>
> <currentVersion>DEV</currentVersion>
>
> </project>
>