You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "JBert (Created) (JIRA)" <ji...@apache.org> on 2012/02/10 16:36:59 UTC
[jira] [Created] (FELIX-3346) File Install doesn't scan when the
framework start level is lower than felix.fileinstall.start.level setting
File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
------------------------------------------------------------------------------------------------------------
Key: FELIX-3346
URL: https://issues.apache.org/jira/browse/FELIX-3346
Project: Felix
Issue Type: Bug
Components: File Install
Environment: Karaf 2.2.5, Windows
Reporter: JBert
1. Set the OSGi start-level to 100 (Karaf default).
2. Configure the following setting in the system properties or factory config for FileInstall:
felix.fileinstall.start.level = 150
3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3346) File Install doesn't scan when the
framework start level is lower than felix.fileinstall.start.level setting
Posted by "Bert Jacobs (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230547#comment-13230547 ]
Bert Jacobs commented on FELIX-3346:
------------------------------------
I'm going to make a new patch... This one's faulty.
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: Bert Jacobs
> Attachments: fileinstall-startlevel.patch
>
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3346) File Install doesn't scan when the
framework start level is lower than felix.fileinstall.start.level setting
Posted by "Jacobs Bert (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacobs Bert updated FELIX-3346:
-------------------------------
Attachment: fileinstall-startlevel.patch
I've attached a patch ("fileinstall-lognstartlvl.patch") which changes
the following things:
- When I configured the "felix.fileinstall.start.level" setting, the
component wouldn't run update or refresh when the framework's start
level is too low. I've introduced a new setting
"felix.fileinstall.active.level" to configure the scan behaviour, e.g.
so you can set it higher than the system bundle start-level so that
the framework bundles resolve first. By default, the file install
component now always updates, irregardless of the
"felix.fileinstall.start.level" setting.
- The bundle start level is now only set when a bundle is installed
and not every time a bundle gets restarted. I'd expect that a user
should be able to override the bundle start level instead of it being
reset each time the file install component triggers a bundle start.
- The bundle-start-level and start-new-bundles settings now work independently. The bundle start-level will get updated when configured, but the bundle will not be persistently started unless the start-setting is also true.
Please note that these changes might warrant a new minor release instead of a bug fix release.
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: Jacobs Bert
> Attachments: fileinstall-startlevel.patch
>
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3346) File Install doesn't scan when the
framework start level is lower than felix.fileinstall.start.level setting
Posted by "JBert (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205510#comment-13205510 ]
JBert commented on FELIX-3346:
------------------------------
Just a note for someone willing to work on this:
fileinstall/src/main/java/org/apache/felis/fileinstall/internal/DirectoryWatcher.java has the following on line 262:
// Waiting for start level
if (FileInstall.getStartLevel().getStartLevel() >= startLevel)
{
Set/*<File>*/ files = scanner.scan(false);
// Check that there is a result. If not, this means that the directory can not be listed,
// so it's presumably not a valid directory (it may have been deleted by someone).
// In such case, just sleep
if (files != null)
{
process(files);
}
}
I'm not sure why that if was added (maybe process(...) has no idea about the start level) but this causes the component to idle when the start level configured in felix.fileinstall.start.level is not reached.
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: JBert
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3346) File Install doesn't scan when the
framework start level is lower than felix.fileinstall.start.level setting
Posted by "Bert Jacobs (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bert Jacobs updated FELIX-3346:
-------------------------------
Attachment: fileinstall-startlevel2.patch
Updated patch (fileinstall-startlevel2.patch) attached.
Any bundles which can't be started at install time will now use a "delayed start"; i.e. when the framework start level is raised, those bundles will attempt another start.
This patch also mitigates a ConcurrentModificationException in the bundleChanged method.
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: Bert Jacobs
> Attachments: fileinstall-startlevel2.patch
>
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (FELIX-3346) File Install doesn't
scan when the framework start level is lower than
felix.fileinstall.start.level setting
Posted by "JBert (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220911#comment-13220911 ]
JBert edited comment on FELIX-3346 at 3/2/12 1:29 PM:
------------------------------------------------------
Issue FELIX-2021 introduced the start level feature. The comments mention that the scanner now waits for the start level because all bundles were automatically started, even when they weren't supposed to.
I'll see if I can supply a patch which fixes this issue but doesn't start bundles unless the right start level is reached.
was (Author: albertdevs):
Issue FELIX-2021 introduced the start level feature. The comments mention that the scanner now waits for the start level because all bundles were started.
I'll see if I can supply a patch which fixes this issue but doesn't start bundles unless the right start level is reached.
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: JBert
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3346) File Install doesn't scan when the
framework start level is lower than felix.fileinstall.start.level setting
Posted by "Bert Jacobs (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230571#comment-13230571 ]
Bert Jacobs commented on FELIX-3346:
------------------------------------
I've been testing the new code today, but I want to do one last test. I guess it'll be ready within the hour.
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: Bert Jacobs
> Attachments: fileinstall-startlevel.patch
>
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-3346) File Install doesn't scan when the
framework start level is lower than felix.fileinstall.start.level setting
Posted by "Guillaume Nodet (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-3346.
------------------------------------
Resolution: Fixed
Fix Version/s: fileinstall-3.1.12
Assignee: Guillaume Nodet
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: Bert Jacobs
> Assignee: Guillaume Nodet
> Fix For: fileinstall-3.1.12
>
> Attachments: fileinstall-startlevel2.patch
>
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3346) File Install doesn't scan when the
framework start level is lower than felix.fileinstall.start.level setting
Posted by "Bert Jacobs (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230650#comment-13230650 ]
Bert Jacobs commented on FELIX-3346:
------------------------------------
Ok, the patch is done.
Please let me know if there are any issues with this patch or the one I submitted for FELIX-3373 (file install logging).
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: Bert Jacobs
> Attachments: fileinstall-startlevel2.patch
>
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3346) File Install doesn't scan when the
framework start level is lower than felix.fileinstall.start.level setting
Posted by "Bert Jacobs (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bert Jacobs updated FELIX-3346:
-------------------------------
Attachment: (was: fileinstall-startlevel.patch)
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: Bert Jacobs
> Attachments: fileinstall-startlevel2.patch
>
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3346) File Install doesn't scan when the
framework start level is lower than felix.fileinstall.start.level setting
Posted by "Guillaume Nodet (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230554#comment-13230554 ]
Guillaume Nodet commented on FELIX-3346:
----------------------------------------
I'm planning to do a release asap, so let me know when you think you'll have a working patch.
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: Bert Jacobs
> Attachments: fileinstall-startlevel.patch
>
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (FELIX-3346) File Install doesn't
scan when the framework start level is lower than
felix.fileinstall.start.level setting
Posted by "JBert (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205510#comment-13205510 ]
JBert edited comment on FELIX-3346 at 2/10/12 3:39 PM:
-------------------------------------------------------
Just a note for someone willing to work on this:
fileinstall/src/main/java/org/apache/felix/fileinstall/internal/DirectoryWatcher.java has the following on line 262:
// Waiting for start level
if (FileInstall.getStartLevel().getStartLevel() >= startLevel)
{
Set/*<File>*/ files = scanner.scan(false);
// Check that there is a result. If not, this means that the directory can not be listed,
// so it's presumably not a valid directory (it may have been deleted by someone).
// In such case, just sleep
if (files != null)
{
process(files);
}
}
I'm not sure why that if was added (maybe process(...) has no idea about the start level) but this causes the component to idle when the start level configured in felix.fileinstall.start.level is not reached.
was (Author: albertdevs):
Just a note for someone willing to work on this:
fileinstall/src/main/java/org/apache/felis/fileinstall/internal/DirectoryWatcher.java has the following on line 262:
// Waiting for start level
if (FileInstall.getStartLevel().getStartLevel() >= startLevel)
{
Set/*<File>*/ files = scanner.scan(false);
// Check that there is a result. If not, this means that the directory can not be listed,
// so it's presumably not a valid directory (it may have been deleted by someone).
// In such case, just sleep
if (files != null)
{
process(files);
}
}
I'm not sure why that if was added (maybe process(...) has no idea about the start level) but this causes the component to idle when the start level configured in felix.fileinstall.start.level is not reached.
> File Install doesn't scan when the framework start level is lower than felix.fileinstall.start.level setting
> ------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3346
> URL: https://issues.apache.org/jira/browse/FELIX-3346
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Environment: Karaf 2.2.5, Windows
> Reporter: JBert
>
> 1. Set the OSGi start-level to 100 (Karaf default).
> 2. Configure the following setting in the system properties or factory config for FileInstall:
> felix.fileinstall.start.level = 150
> 3. Drop something in a folder watched by the File Install component. No bundles get installed or updated.
> Expected behaviour is that bundles get installed, and obviously without them starting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira