You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2016/11/19 00:14:43 UTC
Review Request 53915: Extend JSONMessageFactory to store additional
information about metadata objects on different table events
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53915/
-----------------------------------------------------------
Review request for hive, Sushanth Sowmyan and Thejas Nair.
Bugs: HIVE-15180
https://issues.apache.org/jira/browse/HIVE-15180
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-15180
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a9474c4
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java ea7520d
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/api/TestHCatClientNotification.java a661962
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 4f97cf4
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AddPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateDatabaseMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateFunctionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropDatabaseMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropFunctionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/EventMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/EventUtils.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/InsertMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageDeserializer.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageFactory.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAddPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateDatabaseMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateFunctionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropDatabaseMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropFunctionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONInsertMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageDeserializer.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/53915/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 53915: Extend JSONMessageFactory to store
additional
information about metadata objects on different table events
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53915/#review156372
-----------------------------------------------------------
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/api/TestHCatClientNotification.java (line 138)
<https://reviews.apache.org/r/53915/#comment226589>
how about comparing entire table and tableObj ?
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/api/TestHCatClientNotification.java (line 192)
<https://reviews.apache.org/r/53915/#comment226590>
partition comparison is missing
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java (line 341)
<https://reviews.apache.org/r/53915/#comment226591>
partition comparison is missing
- Thejas Nair
On Nov. 19, 2016, 12:14 a.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53915/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2016, 12:14 a.m.)
>
>
> Review request for hive, Sushanth Sowmyan and Thejas Nair.
>
>
> Bugs: HIVE-15180
> https://issues.apache.org/jira/browse/HIVE-15180
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-15180
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a9474c4
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java ea7520d
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/api/TestHCatClientNotification.java a661962
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 4f97cf4
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AddPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateDatabaseMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateFunctionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropDatabaseMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropFunctionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/EventMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/EventUtils.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/InsertMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageDeserializer.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageFactory.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAddPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateDatabaseMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateFunctionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropDatabaseMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropFunctionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONInsertMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageDeserializer.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53915/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 53915: Extend JSONMessageFactory to store
additional
information about metadata objects on different table events
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53915/#review156688
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Nov. 22, 2016, 11:02 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53915/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2016, 11:02 p.m.)
>
>
> Review request for hive, Sushanth Sowmyan and Thejas Nair.
>
>
> Bugs: HIVE-15180
> https://issues.apache.org/jira/browse/HIVE-15180
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-15180
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a9474c4
> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java ea7520d
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/api/TestHCatClientNotification.java a661962
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 4f97cf4
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AddPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateDatabaseMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateFunctionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropDatabaseMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropFunctionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/EventMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/EventUtils.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/InsertMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageDeserializer.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageFactory.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAddPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateDatabaseMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateFunctionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropDatabaseMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropFunctionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropIndexMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropPartitionMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropTableMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONInsertMessage.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageDeserializer.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53915/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 53915: Extend JSONMessageFactory to store
additional
information about metadata objects on different table events
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53915/
-----------------------------------------------------------
(Updated Nov. 22, 2016, 11:02 p.m.)
Review request for hive, Sushanth Sowmyan and Thejas Nair.
Bugs: HIVE-15180
https://issues.apache.org/jira/browse/HIVE-15180
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-15180
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a9474c4
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java ea7520d
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/api/TestHCatClientNotification.java a661962
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 4f97cf4
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AddPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/AlterTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateDatabaseMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateFunctionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/CreateTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropDatabaseMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropFunctionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/DropTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/EventMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/EventUtils.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/InsertMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageDeserializer.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageFactory.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAddPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONAlterTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateDatabaseMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateFunctionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONCreateTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropDatabaseMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropFunctionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropIndexMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropPartitionMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONDropTableMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONInsertMessage.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageDeserializer.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/53915/diff/
Testing
-------
Thanks,
Vaibhav Gumashta