You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "aiguofer (via GitHub)" <gi...@apache.org> on 2023/05/30 21:13:08 UTC
[GitHub] [arrow-adbc] aiguofer opened a new issue, #716: FlightSQL drivers: Add Cookie middleware for all FlightSQL ADBC drivers
aiguofer opened a new issue, #716:
URL: https://github.com/apache/arrow-adbc/issues/716
The JDBC driver for Arrow Flight SQL uses a Cookie management middleware that sets cookies based on `set-cookie` headers sent back by the server. These can be really useful for a variety of things like observability, sticky-sessions, etc.
It seems like none of the ADBC drivers, including the Java one, use this middleware. It'd be really helpful if they did!
I can make a PR for the Java one, but it looks like some discussion is needed around just making the cookie middleware for other languages like Go and Python (see: https://github.com/apache/arrow/issues/34016#issuecomment-1567766045).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] aiguofer commented on issue #716: */driver/flightsql: Add Cookie middleware for all FlightSQL ADBC drivers
Posted by "aiguofer (via GitHub)" <gi...@apache.org>.
aiguofer commented on issue #716:
URL: https://github.com/apache/arrow-adbc/issues/716#issuecomment-1600984168
sure I can do that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on issue #716: */driver/flightsql: Add Cookie middleware for all FlightSQL ADBC drivers
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #716:
URL: https://github.com/apache/arrow-adbc/issues/716#issuecomment-1574118034
C/C++ also use Go.
An upstream issue would be welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on issue #716: */driver/flightsql: Add Cookie middleware for all FlightSQL ADBC drivers
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #716:
URL: https://github.com/apache/arrow-adbc/issues/716#issuecomment-1593237366
With the upstream addition of the Flight Cookie middleware, I'll look at adding an option to enable that in the flightsql ADBC driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade closed issue #716: */driver/flightsql: Add Cookie middleware for all FlightSQL ADBC drivers
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed issue #716: */driver/flightsql: Add Cookie middleware for all FlightSQL ADBC drivers
URL: https://github.com/apache/arrow-adbc/issues/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on issue #716: */driver/flightsql: Add Cookie middleware for all FlightSQL ADBC drivers
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #716:
URL: https://github.com/apache/arrow-adbc/issues/716#issuecomment-1600975059
@aiguofer Looking at the code, I believe it should just accept the option without issue, but it probably would make sense to add an explicit constant for the option in the Python like we have for the other options. :smile: Would you like to do that and file the PR? If so feel free to tag myself / @lidavidm to review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] aiguofer commented on issue #716: */driver/flightsql: Add Cookie middleware for all FlightSQL ADBC drivers
Posted by "aiguofer (via GitHub)" <gi...@apache.org>.
aiguofer commented on issue #716:
URL: https://github.com/apache/arrow-adbc/issues/716#issuecomment-1600969991
Thanks so much for addressing this!
Question; will the Python wrapper automatically accept the `adbc.flight.sql.rpc.with_cookie_middleware` option with this change or do we need to add that there as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on issue #716: */driver/flightsql: Add Cookie middleware for all FlightSQL ADBC drivers
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #716:
URL: https://github.com/apache/arrow-adbc/issues/716#issuecomment-1573660499
Python uses the Go driver underneath so only the Go driver is relevant here, saving some work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] aiguofer commented on issue #716: */driver/flightsql: Add Cookie middleware for all FlightSQL ADBC drivers
Posted by "aiguofer (via GitHub)" <gi...@apache.org>.
aiguofer commented on issue #716:
URL: https://github.com/apache/arrow-adbc/issues/716#issuecomment-1574083329
Yeah that makes sense! Does the C/C++ driver also use the Go driver under the covers?
The Java ADBC driver should also use the cookie middleware, but that one should be easy to add since it's already part of the arrow project. For the Go client cookie middleware, would it be better to add that to arrow directly? Should I create an issue on that repo to track that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org