You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/03/04 13:34:33 UTC
[GitHub] [cordova-plugin-inappbrowser] wvengen commented on a change in pull
request #427: Fix beforeload for Android <= 7
wvengen commented on a change in pull request #427: Fix beforeload for Android <= 7
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/427#discussion_r262058261
##########
File path: src/android/InAppBrowser.java
##########
@@ -1184,7 +1190,9 @@ public boolean shouldOverrideUrlLoading(String url, String method) {
boolean useBeforeload = false;
String errorMessage = null;
- if(beforeload.equals("yes")
+ if (beforeload.equals("yes") && method == null) {
+ useBeforeload = true;
+ }else if(beforeload.equals("yes")
Review comment:
Does this mean `method` can be `null`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org