You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/08 02:18:58 UTC
[GitHub] [flink] guoweiM opened a new pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
guoweiM opened a new pull request #13558:
URL: https://github.com/apache/flink/pull/13558
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
We use the 'SinkTransformation' to represent the new sink API after the FLIP-143. So this commit renames the 'SinkTransformation' to 'LegacySinkTransformation'.
## Brief change log
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705296235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7279",
"triggerID" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49ecba9b70a2face6928f6db7c0e35c66ac260cb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7279)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705296235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49ecba9b70a2face6928f6db7c0e35c66ac260cb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705296235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7279",
"triggerID" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"triggerType" : "PUSH"
}, {
"hash" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49ecba9b70a2face6928f6db7c0e35c66ac260cb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7279)
* 1f4f2c56473eddab43cdbd1d7d3ff7474113abdf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705296235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7279",
"triggerID" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"triggerType" : "PUSH"
}, {
"hash" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7288",
"triggerID" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"triggerType" : "PUSH"
}, {
"hash" : "96fe5b695afe4db5a654b4c2c30bad6310574a82",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7310",
"triggerID" : "96fe5b695afe4db5a654b4c2c30bad6310574a82",
"triggerType" : "PUSH"
}, {
"hash" : "1438241ab446d5540b9a80ad313e6033502b52f5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1438241ab446d5540b9a80ad313e6033502b52f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96fe5b695afe4db5a654b4c2c30bad6310574a82 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7310)
* 1438241ab446d5540b9a80ad313e6033502b52f5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705296235
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
guoweiM commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705434137
Thanks @gaoyunhaii for your care. I will rename references in the `LegacySinkTransformation`. But for the `PartitionTransformation`:line79 I think it might be typo. Maybe we should use 'Transformation' only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705439346
Yes @guoweiM and @gaoyunhaii the `PartitionTransformation` javadoc is wrong and it is copied (I think) in many transformations. Actually I refactor it as part of this PR https://github.com/apache/flink/pull/13556 so feel free to leave it as is here so that we avoid conflicts :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705439346
Yes @guoweiM and @gaoyunhaii the `PartitionTransformation` javadoc is wrong and it is copied (I think) in many transformations. Actually I refactor it as part of this PR https://github.com/apache/flink/pull/13556 so feel free to leave it as is here so that we avoid conflicts :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705296235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7279",
"triggerID" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"triggerType" : "PUSH"
}, {
"hash" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7288",
"triggerID" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"triggerType" : "PUSH"
}, {
"hash" : "96fe5b695afe4db5a654b4c2c30bad6310574a82",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7310",
"triggerID" : "96fe5b695afe4db5a654b4c2c30bad6310574a82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96fe5b695afe4db5a654b4c2c30bad6310574a82 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-707548093
Hi @guoweiM ! Could you rebase this PR on the current master and then I will merge. Feel free of course to squash the commits here into a single commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705296235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7279",
"triggerID" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"triggerType" : "PUSH"
}, {
"hash" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7288",
"triggerID" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"triggerType" : "PUSH"
}, {
"hash" : "96fe5b695afe4db5a654b4c2c30bad6310574a82",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7310",
"triggerID" : "96fe5b695afe4db5a654b4c2c30bad6310574a82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f4f2c56473eddab43cdbd1d7d3ff7474113abdf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7288)
* 96fe5b695afe4db5a654b4c2c30bad6310574a82 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
guoweiM commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-707578729
ok np.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705300208
Very thanks @guoweiM for opening this PR! It seems that are still some references to `SinkTransformation` in the method comments:
`PartitionTransformation`: line 79
`LegacySinkTransformation` line 40, 81, 93
after the modification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705290770
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 49ecba9b70a2face6928f6db7c0e35c66ac260cb (Thu Oct 08 02:20:47 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
guoweiM commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705434137
Thanks @gaoyunhaii for your care. I will rename references in the `LegacySinkTransformation`. But for the `PartitionTransformation`:line79 I think it might be typo. Maybe we should use 'Transformation' only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
guoweiM commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-707589388
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705296235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7279",
"triggerID" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"triggerType" : "PUSH"
}, {
"hash" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7288",
"triggerID" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"triggerType" : "PUSH"
}, {
"hash" : "96fe5b695afe4db5a654b4c2c30bad6310574a82",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7310",
"triggerID" : "96fe5b695afe4db5a654b4c2c30bad6310574a82",
"triggerType" : "PUSH"
}, {
"hash" : "1438241ab446d5540b9a80ad313e6033502b52f5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7505",
"triggerID" : "1438241ab446d5540b9a80ad313e6033502b52f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96fe5b695afe4db5a654b4c2c30bad6310574a82 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7310)
* 1438241ab446d5540b9a80ad313e6033502b52f5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705296235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7279",
"triggerID" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"triggerType" : "PUSH"
}, {
"hash" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7288",
"triggerID" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"triggerType" : "PUSH"
}, {
"hash" : "96fe5b695afe4db5a654b4c2c30bad6310574a82",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "96fe5b695afe4db5a654b4c2c30bad6310574a82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f4f2c56473eddab43cdbd1d7d3ff7474113abdf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7288)
* 96fe5b695afe4db5a654b4c2c30bad6310574a82 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u closed pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #13558:
URL: https://github.com/apache/flink/pull/13558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
guoweiM edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705434137
Thanks @gaoyunhaii for your care. I will rename references in the `LegacySinkTransformation`. But for the `PartitionTransformation`:line79 I think it might be typo. Maybe we should use 'Transformation' only. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705296235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7279",
"triggerID" : "49ecba9b70a2face6928f6db7c0e35c66ac260cb",
"triggerType" : "PUSH"
}, {
"hash" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7288",
"triggerID" : "1f4f2c56473eddab43cdbd1d7d3ff7474113abdf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f4f2c56473eddab43cdbd1d7d3ff7474113abdf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7288)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM edited a comment on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
guoweiM edited a comment on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-705434137
Thanks @gaoyunhaii for your care. I will rename references in the `LegacySinkTransformation`. But for the `PartitionTransformation`:line79 I think it might be typo. Maybe we should use 'Transformation' only. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on pull request #13558: [FLINK-19511] Rename the 'SinkTransformation' to 'LegacySinkTransformation'
Posted by GitBox <gi...@apache.org>.
guoweiM commented on pull request #13558:
URL: https://github.com/apache/flink/pull/13558#issuecomment-707632432
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org