You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/09/22 09:58:44 UTC

[GitHub] [spark] zhengruifeng opened a new pull request, #43055: [SPARK-45279][PYTHON][CONNECT] Attach plan_id for all logical plans

zhengruifeng opened a new pull request, #43055:
URL: https://github.com/apache/spark/pull/43055

   ### What changes were proposed in this pull request?
   Attach plan_id for all logical plans, except `CachedRelation`
   
   
   ### Why are the changes needed?
   1, all logical plans should contain its plan id in protos
   2, catalog plans also contain the plan id in scala client, e.g.
   
   https://github.com/apache/spark/blob/05f5dccbd34218c7d399228529853bdb1595f3a2/connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala#L63-L67
   
   `newDataset` method will set the plan id
   
   ### Does this PR introduce _any_ user-facing change?
   no
   
   ### How was this patch tested?
   CI
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng closed pull request #43055: [SPARK-45279][PYTHON][CONNECT] Attach plan_id for all logical plans

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #43055: [SPARK-45279][PYTHON][CONNECT] Attach plan_id for all logical plans
URL: https://github.com/apache/spark/pull/43055


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #43055: [SPARK-45279][PYTHON][CONNECT] Attach plan_id for all logical plans

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43055:
URL: https://github.com/apache/spark/pull/43055#issuecomment-1732714144

   thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org