You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "liujiayi771 (via GitHub)" <gi...@apache.org> on 2025/12/14 12:13:18 UTC
[PR] [CORE] Get correct fallback reason on nodes without logicalLink [incubator-gluten]
liujiayi771 opened a new pull request, #11295:
URL: https://github.com/apache/incubator-gluten/pull/11295
## What changes are proposed in this pull request?
This PR adds a fallback mechanism to attempt retrieving the fallback reason from a SparkPlan node's tags when its `logicalLink` is unavailable. Some SparkPlan nodes, such as the `SortExec` generated by Spark's `EnsureRequirements` rule, inherently lack a `logicalLink`. Furthermore, some plan conversion rules in Gluten might omit calling `copyTagsFrom`, leading to the loss of the original `logicalLink`.
In such cases, if the node falls back, the fallback reason might be stored within the node's tags. This change attempts to retrieve the reason from there as a best-effort approach.
## How was this patch tested?
Add a test case when window sort fallback. Before this change, the fallback reason was a generic "Gluten does not touch it or does not support it". After the change, it can display a more precise reason, such as "[FallbackByUserOptions] Validation failed on node Sort", which is retrieved from the physical node's tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Get correct fallback reason on nodes without logicalLink [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11295:
URL: https://github.com/apache/incubator-gluten/pull/11295#issuecomment-3650935612
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Get correct fallback reason on nodes without logicalLink [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11295:
URL: https://github.com/apache/incubator-gluten/pull/11295#issuecomment-3650843111
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Get correct fallback reason on nodes without logicalLink [incubator-gluten]
Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 merged PR #11295:
URL: https://github.com/apache/incubator-gluten/pull/11295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Get correct fallback reason on nodes without logicalLink [incubator-gluten]
Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on PR #11295:
URL: https://github.com/apache/incubator-gluten/pull/11295#issuecomment-3654310296
cc @zhztheplayer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Get correct fallback reason on nodes without logicalLink [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11295:
URL: https://github.com/apache/incubator-gluten/pull/11295#issuecomment-3651639130
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Get correct fallback reason on nodes without logicalLink [incubator-gluten]
Posted by "liujiayi771 (via GitHub)" <gi...@apache.org>.
liujiayi771 commented on PR #11295:
URL: https://github.com/apache/incubator-gluten/pull/11295#issuecomment-3650937365
Before:
<img width="706" height="62" alt="iShot_2025-12-14_18 34 39" src="https://github.com/user-attachments/assets/bdfdd9dc-b239-42f4-b827-78082954e8ed" />
After:
<img width="654" height="63" alt="iShot_2025-12-14_18 06 29" src="https://github.com/user-attachments/assets/a61f2a28-41fa-4f2e-8d67-7c604b25c842" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org