You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/07 07:33:17 UTC
[GitHub] [druid] calvinhkf opened a new pull request #9636: Align library
version
calvinhkf opened a new pull request #9636: Align library version
URL: https://github.com/apache/druid/pull/9636
Align junit and jUnitParams versions to avoid inconsistency. Update version in one module to make library version consistent with that in other modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] calvinhkf commented on a change in pull request #9636:
Align library version
Posted by GitBox <gi...@apache.org>.
calvinhkf commented on a change in pull request #9636: Align library version
URL: https://github.com/apache/druid/pull/9636#discussion_r405226327
##########
File path: extendedset/pom.xml
##########
@@ -58,7 +58,7 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>4.8.1</version>
+ <version>4.12</version>
Review comment:
Yes. It's better. I have made suggested changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #9636: Align
library version
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #9636: Align library version
URL: https://github.com/apache/druid/pull/9636#discussion_r404938818
##########
File path: extendedset/pom.xml
##########
@@ -58,7 +58,7 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>4.8.1</version>
+ <version>4.12</version>
Review comment:
Thanks for cleaning this up! I looked through all uses of junit in the poms, and it looks like this is the only sub-module that explicitly specifies the version. Can we exclude the version here so that it will pick up the version specified in the top level pom?
Similar comment for JUnitParams below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org