You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/22 22:25:57 UTC
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2496: sys/console: Add syscfg to allow restoring echo state after NLIP commands
apache-mynewt-bot commented on pull request #2496:
URL: https://github.com/apache/mynewt-core/pull/2496#issuecomment-783720207
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### sys/console/minimal/src/console.c
<details>
```diff
@@ -336,7 +336,7 @@
ev = NULL;
console_nlip_enable_echo();
return 0;
- /* Ignore characters if there's no more buffer space */
+ /* Ignore characters if there's no more buffer space */
} else if (byte == CONSOLE_NLIP_PKT_START2) {
/* Disable echo to not flood the UART */
console_nlip_disable_echo();
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org