You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/05/01 19:15:08 UTC
Review Request 58887: Sometimes: Command [ambari-server restart]
failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58887/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
Bugs: AMBARI-20906
https://issues.apache.org/jira/browse/AMBARI-20906
Repository: ambari
Description
-------
So from logs it looks like the problem happens when the "view directory watcher" detects change in jar file tries to update the view.
The solution to this is not with proof but a precautionary and preventive of nature.
I have introduced a property "views.directory.watcher.disable" which can be set to "true" to disable the View Directory Watcher.
Disabling will help if ambari does not work fine even after restarts. Another small change is that I have done the method in ViewRegistry to be synchronized. This will remove cases if any where in the view gets simultaneously updated.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java f01df9be7d
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e266dd5693
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 24eceb21c6
Diff: https://reviews.apache.org/r/58887/diff/1/
Testing
-------
Thanks,
Nitiraj Rathore
Re: Review Request 58887: Sometimes: Command [ambari-server restart]
failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58887/#review173496
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On May 1, 2017, 7:16 p.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58887/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 7:16 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20906
> https://issues.apache.org/jira/browse/AMBARI-20906
>
>
> Repository: ambari
>
>
> Description
> -------
>
> So from logs it looks like the problem happens when the "view directory watcher" detects change in jar file tries to update the view.
> The solution to this is not with proof but a precautionary and preventive of nature.
> I have introduced a property "views.directory.watcher.disable" which can be set to "true" to disable the View Directory Watcher.
> Disabling will help if ambari does not work fine even after restarts. Another small change is that I have done the method in ViewRegistry to be synchronized. This will remove cases if any where in the view gets simultaneously updated.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java f01df9be7d
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e266dd5693
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 24eceb21c6
>
>
> Diff: https://reviews.apache.org/r/58887/diff/1/
>
>
> Testing
> -------
>
> Tests cases are clearing. And ambari is coming up properly.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 58887: Sometimes: Command [ambari-server restart]
failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58887/#review173492
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On May 1, 2017, 7:16 p.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58887/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 7:16 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-20906
> https://issues.apache.org/jira/browse/AMBARI-20906
>
>
> Repository: ambari
>
>
> Description
> -------
>
> So from logs it looks like the problem happens when the "view directory watcher" detects change in jar file tries to update the view.
> The solution to this is not with proof but a precautionary and preventive of nature.
> I have introduced a property "views.directory.watcher.disable" which can be set to "true" to disable the View Directory Watcher.
> Disabling will help if ambari does not work fine even after restarts. Another small change is that I have done the method in ViewRegistry to be synchronized. This will remove cases if any where in the view gets simultaneously updated.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java f01df9be7d
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e266dd5693
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 24eceb21c6
>
>
> Diff: https://reviews.apache.org/r/58887/diff/1/
>
>
> Testing
> -------
>
> Tests cases are clearing. And ambari is coming up properly.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 58887: Sometimes: Command [ambari-server restart]
failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58887/
-----------------------------------------------------------
(Updated May 1, 2017, 7:16 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
Bugs: AMBARI-20906
https://issues.apache.org/jira/browse/AMBARI-20906
Repository: ambari
Description
-------
So from logs it looks like the problem happens when the "view directory watcher" detects change in jar file tries to update the view.
The solution to this is not with proof but a precautionary and preventive of nature.
I have introduced a property "views.directory.watcher.disable" which can be set to "true" to disable the View Directory Watcher.
Disabling will help if ambari does not work fine even after restarts. Another small change is that I have done the method in ViewRegistry to be synchronized. This will remove cases if any where in the view gets simultaneously updated.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java f01df9be7d
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e266dd5693
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 24eceb21c6
Diff: https://reviews.apache.org/r/58887/diff/1/
Testing (updated)
-------
Tests cases are clearing. And ambari is coming up properly.
Thanks,
Nitiraj Rathore