You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sachingoel0101 <gi...@git.apache.org> on 2015/11/28 18:51:21 UTC
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1421
[FLINK-2928][web-dashboard] Fix confusing job status visualization in job overview.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sachingoel0101/flink 2928-job-overview
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1421.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1421
----
commit 23c4ad6708fc3a6ef062d35600eb564a188c969d
Author: Sachin Goel <sa...@gmail.com>
Date: 2015-11-28T17:41:14Z
[FLINK-2928][web-dashboard] Fix confusing job status visualization in job overview.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by iampeter <gi...@git.apache.org>.
Github user iampeter commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-162567139
Maybe a top right action button, triggering a Bootstrap dropdown with the Cancel action?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-162331113
Layout is tricky. But the JobID is a very important field (for example to copy for CLI commands) and needs to stay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-162796105
That sounds great. @iampeter thanks for the suggestion. :)
I will see if I can update the PR today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-162585460
I like that solution, @iampeter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-160644285
Nice, I like the label.
Somehow the JobID is missing now. Did you remove that, or was it removed earlier already?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-160908584
I think solving a layout problem by removing another important UI element is not the way to go.
Does it nor work to let the elements that do not fit in the one row automatically float left/down into a second row?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-173624371
Congrats @sachingoel0101. I hope you stick with us :) Do you think you'll be able to finish the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-162207406
I'm not very sure about this. Displaying two rows doesn't look good at all. Maybe @iampeter has a better suggestion here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-160743609
The presence of job id was leading to the cancel button disappearing sometimes due to lack of space which is something very important. I considered a two row approach but that looked ugly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-168634287
Hi @StephanEwen, apologies for the delayed response.
Unfortunately, I haven't been able to work on Flink recently as I've just moved abroad. I've also just joined Samsung, so I will have to check whether I can continue contributing. Since this isn't a blocker issue, I will let you know in a few days if I'll be able to continue working on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-167420226
@sachingoel0101 This still misses the Job ID
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1421#issuecomment-162341452
Makes sense. Lemme figure something out here, and I will post an update in a day or two.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---