[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3507: allow use of string for controller id
URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193251981
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
 ##########
 @@ -22,7 +22,20 @@ import spray.json.DefaultJsonProtocol
 case class InstanceId(val instance: Int, name: Option[String] = None) {
   def toInt: Int = instance
 }
-
+case class StringInstanceId(instance: String) {
 
 Review comment:
   is there a reason to distinguish the two - in other words, could they both be StringInstanceId? (in which case can rename StringInstanceId to InstanceId)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services