You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Denis Stepanov (JIRA)" <ji...@apache.org> on 2011/02/16 14:48:57 UTC

[jira] Created: (TAP5-1446) Improve coercion Collection, Map -> SelectModel

Improve coercion Collection, Map -> SelectModel
-----------------------------------------------

                 Key: TAP5-1446
                 URL: https://issues.apache.org/jira/browse/TAP5-1446
             Project: Tapestry 5
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.2.4
            Reporter: Denis Stepanov


It should use SelectModelFactory with default property "label?". If there is no such property it should have current toString value.

There is probably a bug in SelectModelFactoryImpl:

options.add(new OptionModelImpl(encoder.toClient(label), object));

toClient should be called with "object"

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1446) Improve coercion List -> SelectModel

Posted by "Denis Stepanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Denis Stepanov updated TAP5-1446:
---------------------------------

    Attachment: TAP5-1446.patch

> Improve coercion List -> SelectModel
> ------------------------------------
>
>                 Key: TAP5-1446
>                 URL: https://issues.apache.org/jira/browse/TAP5-1446
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.4
>            Reporter: Denis Stepanov
>         Attachments: TAP5-1446.patch
>
>
> It should use SelectModelFactory. Labels are extracted from objects using strategy pattern. Users can contribute providers for their own objects. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TAP5-1446) Improve coercion List -> SelectModel

Posted by "Denis Stepanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022696#comment-13022696 ] 

Denis Stepanov commented on TAP5-1446:
--------------------------------------

Please see the patch

> Improve coercion List -> SelectModel
> ------------------------------------
>
>                 Key: TAP5-1446
>                 URL: https://issues.apache.org/jira/browse/TAP5-1446
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.4
>            Reporter: Denis Stepanov
>         Attachments: TAP5-1446.patch
>
>
> It should use SelectModelFactory. Labels are extracted from objects using strategy pattern. Users can contribute providers for their own objects. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TAP5-1446) Improve coercion List -> SelectModel

Posted by "Denis Stepanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022696#comment-13022696 ] 

Denis Stepanov commented on TAP5-1446:
--------------------------------------

Please see the patch

> Improve coercion List -> SelectModel
> ------------------------------------
>
>                 Key: TAP5-1446
>                 URL: https://issues.apache.org/jira/browse/TAP5-1446
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.4
>            Reporter: Denis Stepanov
>         Attachments: TAP5-1446.patch
>
>
> It should use SelectModelFactory. Labels are extracted from objects using strategy pattern. Users can contribute providers for their own objects. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-1446) Improve coercion List -> SelectModel

Posted by "Denis Stepanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Denis Stepanov updated TAP5-1446:
---------------------------------

    Description: It should use SelectModelFactory. Labels are extracted from objects using strategy pattern. Users can contribute providers for their own objects.   (was: It should use SelectModelFactory with default property "label?". If there is no such property it should have current toString value.

There is probably a bug in SelectModelFactoryImpl:

options.add(new OptionModelImpl(encoder.toClient(label), object));

toClient should be called with "object")
        Summary: Improve coercion List -> SelectModel  (was: Improve coercion Collection, Map -> SelectModel)

> Improve coercion List -> SelectModel
> ------------------------------------
>
>                 Key: TAP5-1446
>                 URL: https://issues.apache.org/jira/browse/TAP5-1446
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.4
>            Reporter: Denis Stepanov
>
> It should use SelectModelFactory. Labels are extracted from objects using strategy pattern. Users can contribute providers for their own objects. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-1446) Improve coercion List -> SelectModel

Posted by "Denis Stepanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Denis Stepanov updated TAP5-1446:
---------------------------------

    Attachment: TAP5-1446.patch

> Improve coercion List -> SelectModel
> ------------------------------------
>
>                 Key: TAP5-1446
>                 URL: https://issues.apache.org/jira/browse/TAP5-1446
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.4
>            Reporter: Denis Stepanov
>         Attachments: TAP5-1446.patch
>
>
> It should use SelectModelFactory. Labels are extracted from objects using strategy pattern. Users can contribute providers for their own objects. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-1446) Improve coercion List -> SelectModel

Posted by "Denis Stepanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Denis Stepanov updated TAP5-1446:
---------------------------------

    Description: It should use SelectModelFactory. Labels are extracted from objects using strategy pattern. Users can contribute providers for their own objects.   (was: It should use SelectModelFactory with default property "label?". If there is no such property it should have current toString value.

There is probably a bug in SelectModelFactoryImpl:

options.add(new OptionModelImpl(encoder.toClient(label), object));

toClient should be called with "object")
        Summary: Improve coercion List -> SelectModel  (was: Improve coercion Collection, Map -> SelectModel)

> Improve coercion List -> SelectModel
> ------------------------------------
>
>                 Key: TAP5-1446
>                 URL: https://issues.apache.org/jira/browse/TAP5-1446
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.4
>            Reporter: Denis Stepanov
>
> It should use SelectModelFactory. Labels are extracted from objects using strategy pattern. Users can contribute providers for their own objects. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira