You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/06/10 03:26:04 UTC

Review Request 35282: RANGER-543: updated RangerTimeOfDataMatcher to support time ranges that span across midnight

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35282/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-543
    https://issues.apache.org/jira/browse/RANGER-543


Repository: ranger


Description
-------

updated RangerTimeOfDataMatcher to support time ranges that span across midnight


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTimeOfDayMatcher.java 40d86a5 
  agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerTimeOfDayMatcherTest.java b6ca843 

Diff: https://reviews.apache.org/r/35282/diff/


Testing
-------

Verified that time ranges that span across midnight work as expected. Updated unit tests to cover the new scenarios.


Thanks,

Madhan Neethiraj


Re: Review Request 35282: RANGER-543: updated RangerTimeOfDataMatcher to support time ranges that span across midnight

Posted by Selvamohan Neethiraj <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35282/#review87338
-----------------------------------------------------------

Ship it!


Ship It!

- Selvamohan Neethiraj


On June 9, 2015, 9:26 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35282/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 9:26 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-543
>     https://issues.apache.org/jira/browse/RANGER-543
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> updated RangerTimeOfDataMatcher to support time ranges that span across midnight
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTimeOfDayMatcher.java 40d86a5 
>   agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerTimeOfDayMatcherTest.java b6ca843 
> 
> Diff: https://reviews.apache.org/r/35282/diff/
> 
> 
> Testing
> -------
> 
> Verified that time ranges that span across midnight work as expected. Updated unit tests to cover the new scenarios.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>