You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/14 17:46:10 UTC
[GitHub] [accumulo-testing] dlmarion opened a new issue, #248: Agitator not randomly starting / stopping servers
dlmarion opened a new issue, #248:
URL: https://github.com/apache/accumulo-testing/issues/248
The agitator was refactored as part of https://github.com/apache/accumulo-testing/pull/184. I think there is a bug in the new script, specifically the use of the word `RANDOM` instead of the function `$RANDOM` [here](https://github.com/apache/accumulo-testing/blob/main/bin/agitator#L81) and [here](https://github.com/apache/accumulo-testing/blob/main/bin/agitator#L85).
@ctubbsii - can you confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] dlmarion closed issue #248: Agitator not randomly starting / stopping servers
Posted by GitBox <gi...@apache.org>.
dlmarion closed issue #248: Agitator not randomly starting / stopping servers
URL: https://github.com/apache/accumulo-testing/issues/248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] ctubbsii commented on issue #248: Agitator not randomly starting / stopping servers
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #248:
URL: https://github.com/apache/accumulo-testing/issues/248#issuecomment-1279332037
> So, I did some testing, and it's not the use of `RANDOM` vs `$RANDOM`. The log has the same IP being selected over and over again. So, maybe it's something else.
I'm not that familiar with `RANDOM` vs `$RANDOM`, but in testing the existing expressions, they seemed to both work for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] dlmarion commented on issue #248: Agitator not randomly starting / stopping servers
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #248:
URL: https://github.com/apache/accumulo-testing/issues/248#issuecomment-1279347682
I found [it](https://github.com/apache/accumulo-testing/blob/main/bin/agitator#L77). Can't believe I didn't see it earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] dlmarion commented on issue #248: Agitator not randomly starting / stopping servers
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #248:
URL: https://github.com/apache/accumulo-testing/issues/248#issuecomment-1279312467
So, I did some testing, and it's not the use of `RANDOM` vs `$RANDOM`. The log has the same IP being selected over and over again. So, maybe it's something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] ctubbsii commented on issue #248: Agitator not randomly starting / stopping servers
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #248:
URL: https://github.com/apache/accumulo-testing/issues/248#issuecomment-1282783703
@dlmarion Those two lines of code look okay to me. It looks like it's a simplified case where it avoids all the array logic if you're only killing up to 1 node. (max_kill == 1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] ctubbsii commented on issue #248: Agitator not randomly starting / stopping servers
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #248:
URL: https://github.com/apache/accumulo-testing/issues/248#issuecomment-1279341501
I don't see anything immediately obviously wrong with the use of RANDOM to select nodes from the bash array to kill. But, I wouldn't append to the kill array using the index, like the script is currently doing (`array[index]=foo`). Instead, I'd do `array=("${array[@]}" foo)`, which I am more familiar with. I don't know if the former works on older bash, but when testing, it did seem to work on mine, so it could be fine. (I'm running 5.2.2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] dlmarion commented on issue #248: Agitator not randomly starting / stopping servers
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #248:
URL: https://github.com/apache/accumulo-testing/issues/248#issuecomment-1279348987
I'm wondering if [this](https://github.com/apache/accumulo-testing/blob/main/bin/agitator#L76) was meant to be ` if num_hosts == 1 ... `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org