You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/07/12 09:00:21 UTC
[GitHub] [solr] danrosher opened a new pull request, #936: SOLR-16287 : MapStream - remap tuple value(s)
danrosher opened a new pull request, #936:
URL: https://github.com/apache/solr/pull/936
https://issues.apache.org/jira/browse/SOLR-16287
# Description
Enables atomic updates for update stream by remapping a value to tuple, solr will recognise the map as an atomic update, otherwise update stream simply overwrites. Normal Solr requirements for atomic/in-place updates are still necessary.
# Solution
Remap from (k,v) => k -> newKey -> value
e.g. with
map(<stream>,"cand_id=add-distinct") , convert stream tuples from
From:
`
{"cand_id":5718,id:123,v_i:345}
`
To:
`
{
id:123,
v_i:345,
"cand_id": {
"add-distinct": 5718
},
`
# Tests
e.g.
With:
`
new UpdateRequest()
.add(id, "1", "a_ss", "foo", "b_i", "1", "c_d", "3.3", "d_b", "true")
`
Then:
`update(collection1,map(tuple(id="1",a_ss="bar"),"a_ss=add-distinct"))` will **add-distinct** 'bar' to `a_ss` to then contain ['foo','bar'#
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #936: SOLR-16287 : MapStream - remap tuple value(s)
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #936:
URL: https://github.com/apache/solr/pull/936#issuecomment-1192961970
I sent a note to dev mailing list to see if @joel-bernstein can review it ;-) If he can't, I can try, but it's just an area I haven't worked much in!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] danrosher commented on pull request #936: SOLR-16287 : MapStream - remap tuple value(s)
Posted by GitBox <gi...@apache.org>.
danrosher commented on PR #936:
URL: https://github.com/apache/solr/pull/936#issuecomment-1195527186
Will do @epugh . I'll be away for a week after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-16287 : MapStream - remap tuple value(s) [solr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #936:
URL: https://github.com/apache/solr/pull/936#issuecomment-1951491396
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #936: SOLR-16287 : MapStream - remap tuple value(s)
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #936:
URL: https://github.com/apache/solr/pull/936#issuecomment-1293934021
@epugh ping ;) slightly more than a week or so. anything left to do here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #936: SOLR-16287 : MapStream - remap tuple value(s)
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #936:
URL: https://github.com/apache/solr/pull/936#issuecomment-1297144760
FYI, Joel is going to merge this once the new jar for streaming is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #936: SOLR-16287 : MapStream - remap tuple value(s)
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #936:
URL: https://github.com/apache/solr/pull/936#issuecomment-1195499450
Let's give it another few days, and then, if I don't review/merge it, can you bug me? Say Thursday??? Thanks for this @danrosher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #936: SOLR-16287 : MapStream - remap tuple value(s)
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #936:
URL: https://github.com/apache/solr/pull/936#issuecomment-1184570866
Docs are looking nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org