You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/11 13:15:38 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #20802: Only validate Params when DAG is triggered

uranusjr commented on a change in pull request #20802:
URL: https://github.com/apache/airflow/pull/20802#discussion_r782132542



##########
File path: airflow/models/dagbag.py
##########
@@ -398,6 +400,10 @@ def _process_modules(self, filepath, mods, file_last_changed_on_disk):
             dag.fileloc = mod.__file__
             try:
                 dag.timetable.validate()
+                # create a copy of params before validating
+                copied_params = copy.deepcopy(dag.params)
+                copied_params.update(conf or {})

Review comment:
       @ephraimbuddy has this been fixed? From what I can tell `conf` is still not defined correctly, I may be missing something here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org