[jira] [Comment Edited] (JCR-3445) PostgreSQL error with setValidationQueryTimeout

["Luca Tagliani (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500139#comment-13500139 ] 

Luca Tagliani edited comment on JCR-3445 at 11/19/12 10:53 AM:
---------------------------------------------------------------

Hi all,
  the problem remains, because the setValidationQuerytimeout didn't raise any exception.
The problem arise when we try to get a connection from the configured datasource i.e. first line of method getExtraNameCharacters in ConnectionHelper.

While there's no implementation in PostgreSQL jdbc driver, I think we have to avoid the setting at all, instead of surrounding with a try...catch statement.

I submit JCR-3445-1.patch for review.

BR

Luca
                
      was (Author: luca.tagliani):
    Hi all,
  the problem remains, because the setValidationQuerytimeout didn't raise any exception.
The problem arise when we try to get a connection from the configured datasource i.e. first line of method getExtraNameCharacters in ConnectionHelper.

While there's no implementation in PostgreSQL jdbc driver, I think we have to avoid the setting at all, instead of surrounding with a try...catch statement.

I submit this patch for review.

BR

Luca
                  
> PostgreSQL error with setValidationQueryTimeout
> -----------------------------------------------
>
>                 Key: JCR-3445
>                 URL: https://issues.apache.org/jira/browse/JCR-3445
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.4.3, 2.5.2
>         Environment: Linux Ubuntu 10.04 server with PostgreSQL 9.1 remote DB
>            Reporter: Luca Tagliani
>            Assignee: Bart van der Schans
>            Priority: Critical
>             Fix For: 2.4.4, 2.5.3
>
>         Attachments: catalina.out, JCR-3445-1.patch, JCR-3445.patch, repositorySimple.xml
>
>
> In this version inside o.a.j.c.util.db.ConnectionFactory class, it's been added a validationQueryTimeout (line 344).
> The problem is that the use of queryTimeout is not implemented in any PostgreSQL jdbc driver (see http://jdbc.postgresql.org/todo.html Compliance section)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira