[jira] [Commented] (SQOOP-1786) Sqoop2: Stop using JSONValue.parse method call

["Sqoop QA bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222314#comment-14222314 ] 

Sqoop QA bot commented on SQOOP-1786:
-------------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12683211/SQOOP-1786.patch against branch sqoop2.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} failed to apply patch (exit code 1):
{code}error: patch failed: server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java:110
error: server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java: patch does not apply
{code}

{color:green}SUCCESS:{color} Clean was successful

Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/657/console

This message is automatically generated.

> Sqoop2: Stop using JSONValue.parse method call
> ----------------------------------------------
>
>                 Key: SQOOP-1786
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1786
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.4
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1786.patch
>
>
> While investigating SQOOP-1784, I've noticed that {{JSONValue.parse()}} method that we're using everywhere in the code base is [swallowing exceptions|http://json-simple.googlecode.com/svn/trunk/src/main/java/org/json/simple/JSONValue.java] and returning {{null}} on all failure scenarios.
> As this is causing a random {{NullPointerException}} being thrown elsewhere without proper information what went wrong, I would like to migrate to method {{JSONValue.parseWithException()}} instead. Given how much we're parsing JSONs inside Sqoop 2, I would also recommend to create a small Util class that will handle error cases and coverts the {{ParserException}} to {{SqoopException}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)