[GitHub] [superset] eschutho commented on a change in pull request #17345: fix: clear 'delete' confirmation

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #17345:
URL: https://github.com/apache/superset/pull/17345#discussion_r743262109



##########
File path: superset-frontend/src/components/DeleteModal/index.tsx
##########
@@ -52,12 +52,35 @@ export default function DeleteModal({
   title,
 }: DeleteModalProps) {
   const [disableChange, setDisableChange] = useState(true);
+  const [confirmation, setConfirmation] = useState<string>('');
+
+  const hide = () => {
+    setConfirmation('');
+    onHide();
+  };
+
+  const confirm = () => {
+    setConfirmation('');
+    onConfirm();
+  };
+
+  const onChange = (event: React.ChangeEvent<HTMLInputElement>) => {
+    const targetValue = event.target.value ?? '';
+    setDisableChange(targetValue.toUpperCase() !== t('DELETE'));

Review comment:
       this is a tricky thing.. so we would need to have a translation for the capitalized text and the lowercase?
   I wonder if `t('delete').toUpperCase()` would work. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org