You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/10 02:35:31 UTC
[GitHub] [incubator-superset] lilykuang opened a new pull request #10824: fix(databases): test connection api endpoint
lilykuang opened a new pull request #10824:
URL: https://github.com/apache/incubator-superset/pull/10824
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
- fix `extra` field format for test connection api endpoint
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10824: fix(databases): test connection api endpoint
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10824:
URL: https://github.com/apache/incubator-superset/pull/10824#discussion_r486164081
##########
File path: superset/databases/schemas.py
##########
@@ -298,7 +298,9 @@ class DatabaseTestConnectionSchema(Schema):
impersonate_user = fields.Boolean(description=impersonate_user_description)
extra = fields.String(description=extra_description, validate=extra_validator)
encrypted_extra = fields.String(
- description=encrypted_extra_description, validate=encrypted_extra_validator
+ description=encrypted_extra_description,
+ validate=encrypted_extra_validator,
+ allow_none=True,
)
server_cert = fields.String(
description=server_cert_description, validate=server_cert_validator
Review comment:
You probably need `allow_none=True` for server_cert also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #10824: fix(databases): test connection api endpoint
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10824:
URL: https://github.com/apache/incubator-superset/pull/10824
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org