You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/18 15:42:22 UTC

[GitHub] yanghua commented on a change in pull request #6702: [FLINK-10135] The JobManager does not report the cluster-level metrics

yanghua commented on a change in pull request #6702: [FLINK-10135] The JobManager does not report the cluster-level metrics
URL: https://github.com/apache/flink/pull/6702#discussion_r218486848
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java
 ##########
 @@ -111,6 +112,14 @@
 	 */
 	CompletableFuture<ClusterOverview> requestClusterOverview(@RpcTimeout Time timeout);
 
+	/**
+	 * Requests the all the jobs overview.
 
 Review comment:
   Because I saw the implementation of `requestClusterOverview ` combines the completed jobs' overview, but this method would not contains so I refer to `requestMultipleJobDetails`. All right, it seems there is no problem about the "all". Will change it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services