You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/10/25 01:44:50 UTC
[GitHub] rafaelweingartner commented on a change in pull request #2905: Fix
delete domain button in the UI to update only after deleteDomain job finishes
rafaelweingartner commented on a change in pull request #2905: Fix delete domain button in the UI to update only after deleteDomain job finishes
URL: https://github.com/apache/cloudstack/pull/2905#discussion_r228012074
##########
File path: ui/scripts/domains.js
##########
@@ -69,11 +69,23 @@
async: false,
success: function(json) {
var jid = json.deletedomainresponse.jobid;
+ var wasDomainDeletedWithSuccess = false;
+ $.ajax({
+ url: createURL("queryAsyncJobResult&jobId=" + jid),
+ dataType: "json",
+ async: false,
Review comment:
that is a good question. If you take a look, the upper method "deleteDomain" (at line 69), it is already an "async" call. I could for instance, move the code from lines 81-93 to the success function (line 78), but that can cause an odd behavior if the user clicks somewhere in the UI before the method finishing. That is why I decided to roll with the "standard" and use a "sync" call as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services