[jira] [Created] (CALCITE-4238) Don't require each sub-project parser to have its own list of non-reserved keywords

["Julian Hyde (Jira)" <ji...@apache.org>]

Julian Hyde created CALCITE-4238:
------------------------------------

             Summary: Don't require each sub-project parser to have its own list of non-reserved keywords
                 Key: CALCITE-4238
                 URL: https://issues.apache.org/jira/browse/CALCITE-4238
             Project: Calcite
          Issue Type: Bug
            Reporter: Julian Hyde


Since CALCITE-2405 each sub-parser has its own list of non-reserved keywords. This is good, because it allows the sub-parser to make keywords non-reserved (e.g. in DRILL-1065 Drill wanted {{EXEC}} [to be non-reserved|https://issues.apache.org/jira/browse/DRILL-1065?focusedCommentId=14903669&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14903669]) but it still requires each parser to have a list of non-reserved keywords (see e.g. [the list in Babel parser|https://github.com/apache/calcite/blob/eb4011bb4b9d962c2f8e6767cbee8c23435ef939/babel/src/main/codegen/config.fmpp#L37]). And if we add a keyword to Calcite, we usually have to modify the list in each sub-parser.

This proposal would move the list of default non-reserved keywords to a shared config file. This would reduce the amount of code in sub-parsers, and remove the need to edit them when we add a keyword to the base parser.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)