You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/03/12 18:45:16 UTC

Review Request 31994: Performance: Request endpoint takes too long for large cluster

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31994/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.


Bugs: AMBARI-10044
    https://issues.apache.org/jira/browse/AMBARI-10044


Repository: ambari


Description
-------

* Perform same optimization step as with the Upgrade endpoint and calculating summaries


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 09633c7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 9a9bc8a 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 4671ab5 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandStatusSummaryDTO.java ef867b0 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 13943f2 

Diff: https://reviews.apache.org/r/31994/diff/


Testing
-------

Manual cluster deploy + ops to confirm percent complete and appropriate fields getting returned in requests.  Manual testing on perf cluster.

Automated testing pending


Thanks,

Nate Cole


Re: Review Request 31994: Performance: Request endpoint takes too long for large cluster

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31994/#review76265
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On March 12, 2015, 5:45 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31994/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 5:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-10044
>     https://issues.apache.org/jira/browse/AMBARI-10044
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Perform same optimization step as with the Upgrade endpoint and calculating summaries
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 09633c7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 9a9bc8a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 4671ab5 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandStatusSummaryDTO.java ef867b0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 13943f2 
> 
> Diff: https://reviews.apache.org/r/31994/diff/
> 
> 
> Testing
> -------
> 
> Manual cluster deploy + ops to confirm percent complete and appropriate fields getting returned in requests.  Manual testing on perf cluster.
> 
> Automated testing pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 31994: Performance: Request endpoint takes too long for large cluster

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31994/#review76254
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
<https://reviews.apache.org/r/31994/#comment123773>

    Optimization


- Alejandro Fernandez


On March 12, 2015, 5:45 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31994/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 5:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-10044
>     https://issues.apache.org/jira/browse/AMBARI-10044
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Perform same optimization step as with the Upgrade endpoint and calculating summaries
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 09633c7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 9a9bc8a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 4671ab5 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandStatusSummaryDTO.java ef867b0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 13943f2 
> 
> Diff: https://reviews.apache.org/r/31994/diff/
> 
> 
> Testing
> -------
> 
> Manual cluster deploy + ops to confirm percent complete and appropriate fields getting returned in requests.  Manual testing on perf cluster.
> 
> Automated testing pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 31994: Performance: Request endpoint takes too long for large cluster

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31994/#review76261
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On March 12, 2015, 1:45 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31994/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 1:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-10044
>     https://issues.apache.org/jira/browse/AMBARI-10044
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Perform same optimization step as with the Upgrade endpoint and calculating summaries
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 09633c7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 9a9bc8a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 4671ab5 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandStatusSummaryDTO.java ef867b0 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 13943f2 
> 
> Diff: https://reviews.apache.org/r/31994/diff/
> 
> 
> Testing
> -------
> 
> Manual cluster deploy + ops to confirm percent complete and appropriate fields getting returned in requests.  Manual testing on perf cluster.
> 
> Automated testing pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 31994: Performance: Request endpoint takes too long for large cluster

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31994/
-----------------------------------------------------------

(Updated March 12, 2015, 2:27 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.


Bugs: AMBARI-10044
    https://issues.apache.org/jira/browse/AMBARI-10044


Repository: ambari


Description
-------

* Perform same optimization step as with the Upgrade endpoint and calculating summaries


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 09633c7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 9a9bc8a 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 4671ab5 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandStatusSummaryDTO.java ef867b0 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java 13943f2 

Diff: https://reviews.apache.org/r/31994/diff/


Testing (updated)
-------

Manual cluster deploy + ops to confirm percent complete and appropriate fields getting returned in requests.  Manual testing on perf cluster.

Tests run: 2769, Failures: 0, Errors: 0, Skipped: 15

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:56.896s
[INFO] Finished at: Thu Mar 12 14:03:43 EDT 2015
[INFO] Final Memory: 32M/403M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole