You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/21 03:15:30 UTC
[GitHub] [incubator-shardingsphere] JasonKing168 opened a new pull request
#4874: Fix #4852: Add start-index and stop-index assertion for OrderByItem.
JasonKing168 opened a new pull request #4874: Fix #4852: Add start-index and stop-index assertion for OrderByItem.
URL: https://github.com/apache/incubator-shardingsphere/pull/4874
Fixes #4852.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4874: Fix
#4852: Add start-index and stop-index assertion for OrderByItem.
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4874: Fix #4852: Add start-index and stop-index assertion for OrderByItem.
URL: https://github.com/apache/incubator-shardingsphere/pull/4874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4874: Fix
#4852: Add start-index and stop-index assertion for OrderByItem.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4874: Fix #4852: Add start-index and stop-index assertion for OrderByItem.
URL: https://github.com/apache/incubator-shardingsphere/pull/4874#issuecomment-601989125
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4874?src=pr&el=h1) Report
> Merging [#4874](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4874?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/f8d4ad02d849c69f3d78b5f773aeb08cd5acb5ad&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4874/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4874?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4874 +/- ##
============================================
- Coverage 54.70% 54.67% -0.03%
Complexity 436 436
============================================
Files 1138 1138
Lines 20424 20412 -12
Branches 3760 3752 -8
============================================
- Hits 11172 11161 -11
Misses 8547 8547
+ Partials 705 704 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4874?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4874/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `80.13% <0.00%> (-0.88%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4874?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4874?src=pr&el=footer). Last update [f8d4ad0...010a352](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4874?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4874: Fix
#4852: Add start-index and stop-index assertion for OrderByItem.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4874: Fix #4852: Add start-index and stop-index assertion for OrderByItem.
URL: https://github.com/apache/incubator-shardingsphere/pull/4874#issuecomment-601989473
## Pull Request Test Coverage Report for [Build 10460](https://coveralls.io/builds/29516105)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **58.186%**
---
| Totals | [![Coverage Status](https://coveralls.io/builds/29516105/badge)](https://coveralls.io/builds/29516105) |
| :-- | --: |
| Change from base [Build 10459](https://coveralls.io/builds/29515986): | 0.0% |
| Covered Lines: | 11877 |
| Relevant Lines: | 20412 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services