You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by matrosov-nikita <gi...@git.apache.org> on 2017/07/07 15:20:33 UTC
[GitHub] cordova-windows pull request #235: CB-11968: Add support for config-file in ...
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-windows/pull/235
CB-11968: Add support for config-file in config.xml
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
This logic is needed to apply changes using 'device-target' and 'versions' attributes to manifests.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-windows support-config-file
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/235.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #235
----
commit a7850e76fe8d3083b27fdca486afe634c37b01e0
Author: Nikita Matrosov <v-...@microsoft.com>
Date: 2017-07-07T15:09:55Z
CB-11968: Add support for config-file in config.xml
Requires additional logic to support 'device-target' and 'versions' attributes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows issue #235: CB-11968: Add support for config-file in config....
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-windows/pull/235
I'm not familiar with this changeset enough, but I think this probably needs unit tests :)
Once more, ping @stevengill.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org