You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2023/08/12 11:11:48 UTC

[GitHub] [skywalking] wu-sheng commented on issue #11214: [Feature] Ensuring the safety of stopSpan

wu-sheng commented on issue #11214:
URL: https://github.com/apache/skywalking/issues/11214#issuecomment-1675857731

   If you think more carefully, you will see you are wrong.
   You can never check span available when stop, because the active span could be another plugin created.
   
   V2 interceptor has provided you context to propagate span between before and after. But still stop will fail if the active span is not this span.
   
   Think again. SkyWalking had been there for 8+ years, this had been proposed and rejected many times, **because this proposal is wrong**.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org