[GitHub] [hbase] virajjasani commented on a change in pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#discussion_r455697655



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
##########
@@ -343,6 +343,13 @@ private void load() throws IOException {
     }
   }
 
+  /**
+   * Sets the status task for monitoring all the subtasks for Snapshot operation
+   */
+  public void setMonitoredTask(MonitoredTask statusTask) {

Review comment:
       Passing with create() sounds good, this class is anyways IA.Private, we can add new argument to public methods.

##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
##########
@@ -34,22 +37,21 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.locks.ReadWriteLock;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
-
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
-import org.apache.hadoop.hbase.classification.InterfaceAudience;
-import org.apache.hadoop.hbase.classification.InterfaceStability;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.FSDataInputStream;
 import org.apache.hadoop.fs.FileStatus;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
-import org.apache.hadoop.hbase.TableName;
 import org.apache.hadoop.hbase.HBaseInterfaceAudience;
 import org.apache.hadoop.hbase.HConstants;
 import org.apache.hadoop.hbase.HTableDescriptor;
-import org.apache.hadoop.hbase.Stoppable;
 import org.apache.hadoop.hbase.MetaTableAccessor;
+import org.apache.hadoop.hbase.Stoppable;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.classification.InterfaceStability;

Review comment:
       looks like import reorder is due to formatter :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org