You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/10/17 22:10:49 UTC

Review Request 63090: ATLAS-2214: Issue with neq and notNull/ eq and isNull

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63090/
-----------------------------------------------------------

Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2214
    https://issues.apache.org/jira/browse/ATLAS-2214


Repository: atlas


Description
-------

```java
    // When string/boolean attributes use the following sequence of filtering on AtlasVertex attributes then the code
    // runs into NPE
    // 1. boolean attr "x" != false/true        | boolean attr "x" == false/true
    // 2. boolean attr notNull 'query.has("x")  | boolean attr isNull 'query.hasNot("x")'
    // whereas if the sequence is reversed then the NPE is not encountered
    // Similar behavior is exhibited for the string attributes
    // Workaround is to allow null == null value comparision
```


Diffs
-----

  graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/condition/PredicateCondition.java PRE-CREATION 


Diff: https://reviews.apache.org/r/63090/diff/1/


Testing
-------

Via UI and REST calls. Atlas doesn't report 500 for the use case mentioned in the JIRA


Thanks,

Apoorv Naik

Re: Review Request 63090: ATLAS-2214: Issue with neq and notNull/ eq and isNull

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63090/#review188407
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 17, 2017, 10:10 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63090/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 10:10 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2214
>     https://issues.apache.org/jira/browse/ATLAS-2214
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ```java
>     // When string/boolean attributes use the following sequence of filtering on AtlasVertex attributes then the code
>     // runs into NPE
>     // 1. boolean attr "x" != false/true        | boolean attr "x" == false/true
>     // 2. boolean attr notNull 'query.has("x")  | boolean attr isNull 'query.hasNot("x")'
>     // whereas if the sequence is reversed then the NPE is not encountered
>     // Similar behavior is exhibited for the string attributes
>     // Workaround is to allow null == null value comparision
> ```
> 
> 
> Diffs
> -----
> 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/condition/PredicateCondition.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63090/diff/1/
> 
> 
> Testing
> -------
> 
> Via UI and REST calls. Atlas doesn't report 500 for the use case mentioned in the JIRA
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>