You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/01 16:28:01 UTC

[GitHub] codecov-io commented on issue #5313: Fix flaky unit test - remove 'Markup' object in data

codecov-io commented on issue #5313: Fix flaky unit test - remove 'Markup' object in data
URL: https://github.com/apache/incubator-superset/pull/5313#issuecomment-401617372
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5313?src=pr&el=h1) Report
   > Merging [#5313](https://codecov.io/gh/apache/incubator-superset/pull/5313?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/885d7791a05f497a6e07b0b1a6edcbe76bd41fe3?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5313/graphs/tree.svg?token=KsB0fHcx6l&src=pr&width=650&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/5313?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #5313      +/-   ##
   ==========================================
   + Coverage   61.32%   61.33%   +<.01%     
   ==========================================
     Files         369      369              
     Lines       23488    23483       -5     
     Branches     2717     2713       -4     
   ==========================================
   - Hits        14405    14404       -1     
   + Misses       9071     9067       -4     
     Partials       12       12
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5313?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset/assets/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/5313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvYWN0aW9ucy9zbGljZUVudGl0aWVzLmpz) | `32.25% <ø> (+1.95%)` | :arrow_up: |
   | [...t/assets/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/5313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <ø> (ø)` | :arrow_up: |
   | [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvQWRkU2xpY2VEcmFnUHJldmlldy5qc3g=) | `61.9% <ø> (+2.81%)` | :arrow_up: |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/5313/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.7% <100%> (-0.07%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5313?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5313?src=pr&el=footer). Last update [885d779...241b0e9](https://codecov.io/gh/apache/incubator-superset/pull/5313?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org