You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/07/20 08:03:35 UTC
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17701
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
In IMPALA-8131, we allow parquet file schema to have decimal precision
lower than the one in table schema. However, we should check illegal
precisions like 0 or negative values. They will hit a DCHECK in
ColumnType::GetDecimalByteSize(int).
Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
---
M be/src/exec/parquet/parquet-metadata-utils.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17701/1
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17701 )
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7328/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 23:15:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17701 )
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9121/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 08:37:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17701
to look at the new patch set (#2).
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
In IMPALA-8131, we allow parquet file schema to have decimal precision
lower than the one in table schema. However, we should check illegal
precisions like 0 or negative values. They will hit a DCHECK in
ColumnType::GetDecimalByteSize(int).
Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
---
M be/src/exec/parquet/parquet-metadata-utils.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17701/2
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17701 )
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
Patch Set 3: Code-Review+2
Carry on Zoltan's +2.
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 23:14:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17701
to look at the new patch set (#3).
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
In IMPALA-7087, we allow parquet file schema to have decimal precision
lower than the one in table schema. However, we should check illegal
precisions like 0 or negative values. They will hit a DCHECK in
ColumnType::GetDecimalByteSize(int).
Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
---
M be/src/exec/parquet/parquet-metadata-utils.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/17701/3
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17701 )
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
In IMPALA-7087, we allow parquet file schema to have decimal precision
lower than the one in table schema. However, we should check illegal
precisions like 0 or negative values. They will hit a DCHECK in
ColumnType::GetDecimalByteSize(int).
Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Reviewed-on: http://gerrit.cloudera.org:8080/17701
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/parquet-metadata-utils.cc
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17701 )
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Jul 2021 05:26:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17701 )
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9120/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 08:32:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17701 )
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 23:15:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17701 )
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
Patch Set 3:
(1 comment)
Thank for the quick review, Zoltan!
http://gerrit.cloudera.org:8080/#/c/17701/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17701/2//COMMIT_MSG@9
PS2, Line 9: IMPALA-7087
> IMPALA-8131 is about different scale, IMPALA-7087 is about different precis
Oops, done
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 08:48:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17701 )
Change subject: IMPALA-10808: Fix crash on illegal decimal precision in parquet file schema
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Thanks for fixing this! I only had a small comment about the commit message.
http://gerrit.cloudera.org:8080/#/c/17701/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17701/2//COMMIT_MSG@9
PS2, Line 9: IMPALA-8131
IMPALA-8131 is about different scale, IMPALA-7087 is about different precision. (they were fixed in the same commit)
--
To view, visit http://gerrit.cloudera.org:8080/17701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If84fe14740aea97461ebccedffa4c2ca393333d8
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 08:32:42 +0000
Gerrit-HasComments: Yes