You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/10/21 02:22:57 UTC

[GitHub] [echarts] Ovilia opened a new pull request #15916: fix(bar-race): label value animation duration after sorting

Ovilia opened a new pull request #15916:
URL: https://github.com/apache/echarts/pull/15916


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   
   Bar-racing interpolated value is not correct. This is because when the sorting order changes, the value animation duration takes the whole animation duration. For example, if the `animationDurationUpdate` is 5 seconds and the bar order changes at the 4th second. After changing order, the value animation takes another 5 seconds to complete (rather than 1 second).
   
   https://user-images.githubusercontent.com/779050/138200004-f84eccfb-d92c-4ad6-b30b-425b8bb14e5d.mov
   
   ### After: How is it fixed in this PR?
   
   It doesn't take 5 seconds after sorting.
   
   https://user-images.githubusercontent.com/779050/138200139-d6df0019-6c84-430d-95e7-b8085b73d554.mov
   
   
   ## Misc
   
   <!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
   
   - [ ] The API has been changed (apache/echarts-doc#xxx).
   - [x] This PR depends on ZRender changes (ecomfe/zrender#842).
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15916: fix(bar-race): label value animation duration after sorting

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15916:
URL: https://github.com/apache/echarts/pull/15916#issuecomment-951662355


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15916: fix(bar-race): label value animation duration after sorting

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15916:
URL: https://github.com/apache/echarts/pull/15916#issuecomment-948196611


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.
   
   This PR depends on [ZRender](https://github.com/ecomfe/zrender) changes. Please update the ZRender dependency to the latest nightly version including this change, which takes place everyday at 8:00 UTC (16:00 Beijing Time).
   You can use `npm i zrender@npm:zrender-nightly` to update package.json.
   If you have any question about this, please leave a comment and we will give you extra help on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia merged pull request #15916: fix(bar-race): label value animation duration after sorting

Posted by GitBox <gi...@apache.org>.
Ovilia merged pull request #15916:
URL: https://github.com/apache/echarts/pull/15916


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org